Function as boolean

[luckydead]

Hello,


i have a problem making this function to boolen.

I want to make if boolen is false then to return back to main sub, not to continue with next stuff in code

Public Function InputBoxTest()
    inputData = InputBox("What is your select?" & vbCrLf & "You will need to write again the select number" & vbCrLf & "This will generate automatic the design view in the end.", "Select ID")
    If inputData = "" Then
        'MsgBox inputData
        MsgBox "Please enter some number"
        Exit Function
    End If
End Function

Public Function InputBoxTest() as Boolean
Dim permit As Boolean
 inputData = InputBox("What is your select?" & vbCrLf & "You will need to write again the select number" & vbCrLf & "This will generate automatic the design view in the end.", "Select ID")
    If inputData = "" Then
        permit = False
        MsgBox "Please enter some number"
    Else
        permit = True
    End If
    InputBoxTest=permit
End Function

I'm not sure do i make it correct.

and in my main form code when press button, if InputBoxTest returns false then to return back in sub.

Private Sub Command21_Click()

if InputBoxTest = False Then
Exit Sub
End if

End Sub

[CJ_London]

that is not how you use a function - you need to call it

if InputBoxTest = False Then
Not sure what you are doing to paste your code, but it is very difficult to read with the html code mixed in

edit - see you have fixed it

now realise you have not declared inputData as a string within the function

[luckydead]

so you mean to change Public Function to Public Sub ?

[Welshgasman]

I'd test that it returns 'something', but for something like that I'd just use InputBox in the actual code?

[luckydead]

my question was does i make correct the function and check in main form.
If i make some mistake to correct me how it should be correct way.

For now it works for me the result. The idea is to use it in function because i will call different stuff and i do not want to write tons of lines, better 1 function call and do the trick.

[Minty]

Your function will work but how are you returning the value input into the input box?
And if this is a general function how would you ensure that if a date was required instead of a string or a number that it was validated?

I admire you trying to re-use or modularise your code, but the text in this example makes it very single purpose.

It would probably be better a sub within the form or just put a control on the form that requires this and check it's contents.
If you need to check more than one thing on the form before running the action, then you can loop through the required controls and present a single message box telling the und user what is missing.

Repeatedly prompting a user for inputs in to input boxes is not a great way to get data IMHO, use a form and it gives you much better control over what the user is doing.

[luckydead]

yeah, the problem was that i cannot call the Select method from the Query design and use it in function, thats why only option was for me to make additional box that user will put the same select number second time, so the function to work correct. I just didn't find any information related to this from Query Design, my field is "select" text and it has properties as " Like [your select] , and i just cant find a good way to get from this the same number.

Thank you, for confirm that this way that i manage the stuff is correct.
Im newbie as VBA, but as vb.net would be better for me doing stuff ;]

[Minty]

If you had a form with the "Select" number control on it, you can refer to it in queries provided the form is open.

By the way SELECT is a dreadful name for a field or control as it is a SQL statement use in almost every query!


In your query it would read something like

SELECT field1 , field2 
FROM tbYourTable
WHERE Field3 = [Forms]![YourFormName]![YourControlName]

[CJ_London]

so you mean to change Public Function to Public Sub ?

no - your calling code is not calling the function

however sounds like you are having users interact directly with the query which is not a good idea. As others have said, use a form with a textbox control for the user to enter a value and a button to open the query if something has been entered

[Welshgasman]

In fact use a combo, so they can only enter a value that exists?