For/Next Control Statement Issues

[nick404]

I have this code run behind my submit button to double check that all txt boxes and cbo's are filled in before submitting the data.

Dim c As Control
For Each c In Me.Controls
    If c.ControlType = acTextBox Then
        If IsNull(c.Value) Or c.Value = "" Then
            MsgBox "Please fill the form to completion before submission.", vbOKOnly, "Missing Information"
            Exit Sub
        End If
    If c.ControlType = acComboBox Then
        If IsNull(c.Value) Or c.Value = "" Then
            MsgBox "Please fill the form to completion before submission.", vbOKOnly, "Missing Information"
            Exit Sub
        End If
    End If
End If
Next

However I get the error "Next without For"

EDIT: Updated code, all I did was add an extra 'End if' before the Next. Not sure why this worked but it did

The code works well for all null textboxes but does not catch if the combo boxes are null. Any ideas?

[JoeM]

EDIT: Updated code, all I did was add an extra 'End if' before the Next. Not sure why this worked but it did

You need and END IF for every IF ... THEN, if you do not complete statement all on one line.
It looks like you didn't have one originally for your first "IF ... THEN" statement.

[nick404]

Oh yes you are right the very first one was neglected.

The code catches any null textboxes and presents the message just fine, but it does not seem to work for the combo boxes.
Any one have a clue as to why?

[nick404]

*Resolved.
If anyone is wondering I had to move my bottom End If to the top to the very fist IF statement.

Dim c As Control
For Each c In Me.Controls
    If c.ControlType = acTextBox Then
        If IsNull(c.Value) Or c.Value = "" Then
            MsgBox "Please fill the form to completion before submission.", vbOKOnly, "Missing Information"
            Exit Sub
        End If
    End If
    If c.ControlType = acComboBox Then
        If IsNull(c.Value) Or c.Value = "" Then
            MsgBox "Please fill the form to completion before submission.", vbOKOnly, "Missing Information"
            Exit Sub
        End If
    End If
End If -> moved from here to where blue End If is
Next

[JoeM]

*** deleted ***