syntax error

[Redm4n83]

Hello



Having issues with a syntax error of sorts.

Please see attached file.

If you open up form "Customers"
Select anything from the combobox, Then select a customer and click on the "Edit Customer Info" button
The correct form opens up and has no issues.

However, If i do not select a customer, and go straight to the edit button it comes up with a syntax error.

Sooooo. I have then copied and pasted this form to see what i can do to rectify the issue. Ive gone to Convert form macros to VBA, and it then has red text through the important part of the code as you will find in the form "Customers_Test"

Ideally i would prefer the VBA code instead of the macro. This way i can add in an Ifnull to the code to stop all error and also allow me to modify a little more.
Can someone please look at how i can rectify the red line issue in the "Customers_Test" form.

Secondly.... This one is not too major for the time being. But if someone can assist with a Requery or refresh, As you will find that when the customer information is updated, (First or Last name) it is not updated automatically in the listbox when i close the Customer update form and return naturally back to the Customers list.
Ive attempted the "OnCurrent" event, but this does not change anything unless i click on the actual form to make it current.


Thanks in advance.
Test.zip

[Welshgasman]

Not going to download and unzip a file, just for a few lines of code.
Are you checking that the combo actually has a value? and how are you using it in code.?

[June7]

1. Concatenation is not right. Correct code:

Docmd.OpenForm "CustomerInfo_F", acNormal, "", "[ID]=" & Me.Inactive_Listbox, , acNormal

DoCmd.OpenForm "CustomerInfo_F", acNormal, "", "[ID]=" & Me.All_Listbox, , acNormal

2. Options. Have listbox form Requery its own listbox or have the customer edit form requery the listbox.

Here's a trick to get familiar with. Open a form with acDialog and code execution from the calling form will suspend until the called form closes.

So Customer form can have Me.Inactive_Listbox.Requery after DoCmd.OpenForm.

I don't use macros but I expect acDialog can be specified in macro as well as VBA.

[Redm4n83]

wow, other forums i have been on in the past have got super upset if the file was not attached to the thread.

When being used as a macro created by Access it works fine, except for the error if nothing is selected from the listbox, however that part is not important.
The code that was extracted from converting the macro to VBA is as follows

Private Sub Active_Edit_Button_Click()On Error GoTo Active_Edit_Button_Click_Err


'  The line directly below is the one with error in it
    Docmd.OpenForm "CustomerInfo_F", acNormal, "", "[ID]=" [&Active_Listbox], , acNormal
'  The line directly above is the one with error in it


Active_Edit_Button_Click_Exit:
    Exit Sub


Active_Edit_Button_Click_Err:
    MsgBox Error$
    Resume Active_Edit_Button_Click_Exit


End Sub

[Redm4n83]

fantastic.
Thank you June7. Much appreciate your efforts in assisting.

Thanks

[June7]

Did you read post 3?

Often an issue can easily be resolved by posting the few lines of code of concern. Attaching a file as well never hurts.

[Redm4n83]

yeah i read your post, and have replied. Thanks again
Have added a reputation point for you