Update table using code problem

[krpurcel]

Hi,



Trying to update one field in all records in a table using code attached to a button. Real basic stuff. The code isn't working. The code runs, but I'm adding a new record instead of updating the existing records

It's been several years since I did any of this. How do I update ALL the records instead of adding one new one?

Here's the code.

Dim v_team_selected As String
v_team_selected = Combo26


MsgBox (v_team_selected)


Dim db As Database
Set db = CurrentDb
Dim rs As Recordset
Set rs = db.OpenRecordset("Game_Records")


rs.AddNew
    rs!team_selected = v_team_selected
    MsgBox ("Inside the AddNew. Variable = " + v_team_selected "Next step is update.")
    rs.Update
    MsgBox ("Update step just finished")
rs.Close
    MsgBox ("rs closed")
Set rs = Nothing
MsgBox ("finish!")

Thanks for looking and any advice!

[moke123]

rs.edit instead of rs.AddNew

Although you can do it with an update query instead of a rs.

[Welshgasman]

I would have hoped that

rs.AddNew

would have given it away?

You might also want to use Debug.Print for output, especially if you have more than a few records to update. Clickling MSGBOX twice per record, is going to get old very quickly.

[krpurcel]

Welshgasman,

Yes, it was a definite clue. But I could not remember EDIT. And am evidently more challenged than I realized since I wasn't able to google it up. Thanks for the help!

[moke123]

Welshgasman,

Yes, it was a definite clue. But I could not remember EDIT. And am evidently more challenged than I realized since I wasn't able to google it up. Thanks for the help!

That's where intellisense comes in handy.

[krpurcel]

And intellisense wasn't turned on. Forgot all about that. Thanks moke123!

[Welshgasman]

And intellisense wasn't turned on. Forgot all about that. Thanks moke123!

I did not even know you could turn it off?

So you have one over on me.

[moke123]

I did not even know you could turn it off?

So you have one over on me.

Can You? I always thought it was an early/Late binding thing.

[Micron]

I suspect that if you can, it is determined by the Compile on Demand option, which I take to mean that when off, a procedure isn't compiled until it is called. Or does it refer to the whole module, regardless if form/report, standard or user defined class? Not explained very well here

https://learn.microsoft.com/en-us/of...ons-dialog-box

[moke123]

Found it, I think.
In the VBE options- Autolist Members

[Micron]

Crap! I had another thread in my noggin. It was about compiling, not intellisense.