Shift time defaulting to 2 hours

[bradp1979]

Not sure why, I can't find the answer by reading the code, but in the fee calculator (Shown here), if the hours worked (like #1) are less than 2 hours, it automatically rounds up to 2 hours.


Now, there is a module called: basFeeCalcTotals_RoundUp, but after reading the entire thing, attached as a document, I can't find anything that tells it to round up.

I'm also attaching as a document the code for the frmFeeCalculator. Can someone with more experienced eyes please read the code and tell me why it's rounding automatically up to 2 hours?

Thank you!

Codes.doc

[ssanfu]

It is not in "basFeeCalcTotals_RoundUp", it is in "basPPAStaffingWorksheet".

Here is the Sub name and the section of code (in blue):

Public Function calcLaborSubTotal()
    Dim db As Database
    Dim rst As Recordset
    Dim sql As String
    Dim ShiftStartDateTime As Date
    Dim ShiftEndDateTime As Date
    Dim ShiftEndDate As Date
    Dim ShiftLength As Single
    Dim SubTotal As Currency
    Dim strSubTotal As String
    Dim SubLaborTotal As Currency
    Dim strSubLaborTotal As String
    Dim SubGratTotal As Currency
    Dim strSubGratTotal As String
    Dim GratTotal As Currency
    Dim strGratTotal As String
    Dim length As Byte
    Dim LaborTotal As Currency
    Dim strLaborTotal As String
    Dim LaborTotalLength As Byte
    Dim GratTotalLength As Byte
    Dim lngEventID As Long
    Dim SubGratuityTotal As Currency
    Dim tblSubLaborTotal As Currency
    Dim lngPPAStaffingWorksheetID As Long
    
    
    
    ShiftStartDateTime = Format(Forms!frmEvent!txtEventDate, "Short Date") & " " & Forms!frmFeeCalculator!chldfsubPPAStaffingWorksheet!txtStartTime
    If Forms!frmFeeCalculator!chldfsubPPAStaffingWorksheet!txtStartTime > Forms!frmFeeCalculator!chldfsubPPAStaffingWorksheet!txtEndTime Then
        ShiftEndDate = Forms!frmEvent!txtEventDate + 1
        ShiftEndDateTime = ShiftEndDate & " " & Forms!frmFeeCalculator!chldfsubPPAStaffingWorksheet!txtEndTime
    Else
        ShiftEndDateTime = Format(Forms!frmEvent!txtEventDate, "Short Date") & " " & Forms!frmFeeCalculator!chldfsubPPAStaffingWorksheet!txtEndTime
    End If
    
    If (ShiftEndDateTime - ShiftStartDateTime) * 24 < 2 Then
        ShiftLength = 2
    Else
        ShiftLength = (ShiftEndDateTime - ShiftStartDateTime) * 24
    End If
<snip>

[bradp1979]

Sweet. I changed it by removing the "ShiftLength=2 Else" so now it just reads: If (ShiftEndDateTime - ShiftStartDateTime)*24 < 2 Then ShiftLength = (ShiftEndDateTime-ShiftStartDateTime) * 24.

Thanks again!

[ssanfu]

Have you thought through the logic???


Answer me this: What is the value of "ShiftLength" if the shift length is greater than 2???
I think "ShiftLength" will be zero/NULL........
I would hate to work for you for more that 2 hours a day.



You changed the code to this, but this calculates the shift length ONLY IF the length is less than 2 hrs!!!

    If (ShiftEndDateTime - ShiftStartDateTime) * 24 < 2 Then  'this calculates the shift length ONLY IF the length is less than 2 hrs!!!
        ShiftLength = (ShiftEndDateTime - ShiftStartDateTime) * 24    
    End If

What about if the shift length is Greater Than 2 hrs??



It would be better to comment out the statements you don't want to use:

 '   If (ShiftEndDateTime - ShiftStartDateTime) * 24 < 2 Then  
 '       ShiftLength = 2
 '   Else

        ShiftLength = (ShiftEndDateTime - ShiftStartDateTime) * 24    'this calculates the shift length

 '   End If

I'm just sayin............

[bradp1979]

Incidentally, on one person's computer, it wasn't calculating it correctly. This is what the code says:

If (ShiftEndDateTime - ShiftStartDateTime) * 24 < 2 Then
ShiftLength = (ShiftEndDateTime - ShiftStartDateTime) * 24

Else
ShiftLength = (ShiftEndDateTime - ShiftStartDateTime) * 24
End If

No problems, it now works on everyone's computers, regardless of the number of hours.

[ssanfu]

Yep, that is another way to handle it. Although I would still have commented out the line

'       ShiftLength = 2

instead of deleting it. In the future, you could see what was changed.... but that is me.