code not working

[jj1]

I don't know what I am doing wrong when I login as user Y= 3 then it gives me error 2467. "the expression you entered refers to an object that is closed or does not exist."
and take me to the code line highlighted below.
I think it's confusing Y for 1, 2 and 3 as if I comment 1 and 2 code then 3 works fine and vice versa.

Private Sub Command10_Click()
If IsNull(txtUsername) Then
        MsgBox "Invalid Username"
        Exit Sub
End If
    If IsNull(txtPassword) Then
        MsgBox "Invalid Password"
        Exit Sub
End If
Dim X As Long
X = Nz(DLookup("UserID", "UserT", "Username='" & txtUsername & "' AND Password='" & txtPassword & "'"))
If X > 0 Then
 Dim Y As Long
    Y = Nz(DLookup("GroupID", "GroupXUserT", "UserID='" & X & "'"))
    
    'MsgBox "" & Y & ""
    'We have a valid user
    If Y = 1 Or 2 Then
        DoCmd.OpenForm "MainMenu"
        Forms!MainMenu!txtUserID = X
        LogIt X, "User Logon"
        Forms!MainMenu!txtUsername = txtUsername
        DoCmd.Close acForm, "LoginF"
    End If
Else
    MsgBox "Invalid Logon"
End If
If Y = 3 Then
        DoCmd.OpenForm "MainMenu"
        Forms!MainMenu!txtUserID = X
        LogIt X, "User Logon"
        Forms!MainMenu!txtUsername = txtUsername        
DoCmd.Close acForm, "LoginF"
        Forms!MainMenu!Command27.Visible = False
    End If

[orange]

Try stepping through the code

[Rawb]

I'm only guessing here, but you're confusing Access by referencing a Form Control without using the Me! prefix. It's working before that line because before that point, you only have one Form Control with the name txtUserName. As soon as you open the MainMenu Form, however, Access gets confused (because there's a txtUsername control on both the current Form and the MainMenu Form now). When referencing Controls on a local Form, you should always use Me!ControlName instead of just ControlName.

Private Sub Command10_Click()
If IsNull(Me!txtUsername) Then
        MsgBox "Invalid Username"
        Exit Sub
End If
    If IsNull(Me!txtPassword) Then
        MsgBox "Invalid Password"
        Exit Sub
End If
Dim X As Long
X = Nz(DLookup("UserID", "UserT", "Username='" & Me!txtUsername & "' AND Password='" & Me!txtPassword & "'"))
If X > 0 Then
 Dim Y As Long
    Y = Nz(DLookup("GroupID", "GroupXUserT", "UserID='" & X & "'"))
    
    'MsgBox "" & Y & ""
    'We have a valid user
    If Y = 1 Or 2 Then
        DoCmd.OpenForm "MainMenu"
        Forms!MainMenu!txtUserID = X
        LogIt X, "User Logon"
        Forms!MainMenu!txtUsername = Me!txtUsername
        DoCmd.Close acForm, "LoginF"
    End If
Else
    MsgBox "Invalid Logon"
End If
If Y = 3 Then
        DoCmd.OpenForm "MainMenu"
        Forms!MainMenu!txtUserID = X
        LogIt X, "User Logon"
        Forms!MainMenu!txtUsername = Me!txtUsername        
DoCmd.Close acForm, "LoginF"
        Forms!MainMenu!Command27.Visible = False
    End If

It's also possible that there's not a txtUsername Control on the MainMenu Form.

[John_G]

Your problem may be here: If Y = 1 Or 2 Then

You have the syntax wrong - it has to be : If Y = 1 Or Y = 2 Then


The expression "1 or 2" evaluates to 3, i.e. non-zero, i.e. True, so "If Y = 1 or 2" always evaluates to True, causing the first If..endif block to be executed.

But if Y = 3, the second If..Endif is executed AS WELL!

fix the If and see if that works.

[jj1]

That's the answer. Thanks I got it