Arguement not optional - INSERT INTO sql command

[shabbaranks]

Hi guys,



Im all a kuffufel trying to get my form data into a table with my sql. Am I right in thinking insert into will append the form values to the selected table - or am I doing it incorrectly?

Private Sub AddCont_btn_Click()
    Dim Dbtelnum As Double
    Dim strEmailAdd As String
    Dim mySQL As String
    Dim strFirstname As String
    Dim strLastName As String
    Dim lngCompanyID As Long
    
    lngCompanyID = Nz(DLookup("ID", "CompanyInfo_tbl", "[Company]= '" & [NewContact_Combo] & "'"), 0)
    strFirstname = Me.FirstName_txtbx
    strLastName = Me.LastName_txtbx
        
    If Me.telnumb_txtbx = "" Or IsNull(Forms![NewContact_Frm]![telnumb_txtbx]) Then
    Dbtelnum = "0"
    Me.telnumb_txtbx = Dbtelnum
    End If
    
    If Me.emailadd_txtbx = "" Or IsNull(Forms![NewContact_Frm]![emailadd_txtbx]) Then
    strEmailAdd = "unknown"
    Me.emailadd_txtbx = strEmailAdd
    End If
    
    If Me.FirstName_txtbx = "" Or IsNull(Forms![NewContact_Frm]![FirstName_txtbx]) Then
        MsgBox "Please Add The Persons First Name", vbInformation
        Me.FirstName_txtbx.SetFocus
    Exit Sub
End If
        
If Me.LastName_txtbx = "" Or IsNull(Forms![NewContact_Frm]![LastName_txtbx]) Then
        MsgBox "Please Add The Persons Last Name", vbInformation
        Me.LastName_txtbx.SetFocus
    Exit Sub
End If
If Me.emailadd_txtbx = "" Or IsNull(Forms![NewContact_Frm]![emailadd_txtbx]) Then
strEmailAdd = "unknown"
End If
DoCmd.SetWarnings False
DoCmd.RunSQL = "INSERT INTO (CompanyContact_tbl FirstName, Surname, TelNumber, CompanyID, EmailAddress " & _
"Values '" & strFirstname & "', '" & strLastName & "', Dbtelnum, lngCompanyID, '" & strEmailAdd & "' )"
DoCmd.SetWarnings True
Me!NewContact_Frm.Form.Requery
Clearfield
End Sub

Thanks for any help

[pbaldy]

The correct syntax:

INSERT INTO TableName(Field1, Field2,...)
VALUES(Value1, Value2,...)

you also need to concatenate each value, with the appropriate delimiters. This may help:

http://www.baldyweb.com/BuildSQL.htm

[shabbaranks]

Thanks helped me to no extent

DoCmd.RunSQL "INSERT INTO CompanyContact_tbl ([FirstName], [SURNAME], [TelNumber], [CompanyID], [EmailAddress]) VALUES ('" & strFirstname & "', '" & strLastName & "', '" & Dbtelnum & "', " & lngCompanyID & ", '" & strEmailAdd & "')"

[pbaldy]

Happy to not help then.

[shabbaranks]

haha... Could you explain to me how you should seperate sql into lines properly please? Ive never really understood how you should do it but I would say (based on the error the code is red) that I have written it incorrectly.

    DoCmd.RunSQL "INSERT INTO CompanyContact_tbl ([Company], [CompanyID], [Adress1], [Adress2], [Adress3], [Adress4] " & _
    "[Adress5], [Adress6], [PostCode], [MainPhoneNumber], [Website] " & _
    "VALUES '" & strCompanyName & "', " & lngNewID & ", '" & strADDL1 & "', '" & strADDL2 & "', '" & strADDL3 & "', '" & strADDL4 & "', '" & strADDL5 & "' & _
    " & strADDL6 & "', '" & strPostCode & "', " & DMainNum & ", '" & strWebSite & "')"

Thanks

[pbaldy]

For starters, breaking to the last line you've got a line break in the middle of a string. Try keeping literal strings intact.