code logic error

[mejia.j88]

What do you mean by: Is it conceivable to have the values being tested in a table? The values I'm entering or the values I am testing against?
i can definitely put hte values im testing agaisnt in a table; it will have to be queried because the cut type and size come from a table containing individual part numbers (a ton of part numbers).
I'm not 100% sure i understand the method you are suggesting :-/

[pbaldy]

I mean the values like 0.10825 in the first test. If you can get that from a table, you don't need all the code you have now. My entire checkmeasurements function might look like:

    Dim VariableName As Double
    VariableName = ValueIGetFromTheTableSomehow

    If Val(Me.txtMeasurement1) > Val(VariableName) Then          'value comparison
        MsgBox ("Measurement entered is too large")         'what it does if measurement is wrong
        Me.txtMeasurement1.SetFocus
        checkmeasurements = False
    ElseIf Val(Me.txtMeasurement2) > Val(VariableName) Then
        MsgBox ("Measurement entered is too large")
        Me.txtMeasurement2.SetFocus
        checkmeasurements = False
    ElseIf Val(Me.txtMeasurement3) > Val(VariableName) Then
        MsgBox ("Measurement entered is too large")
        Me.txtMeasurement3.SetFocus
        checkmeasurements = False
    Else
        checkmeasurements = True
    End If

[John_G]

Hi -

Allow me to jump in -

I don't think your checkmeasurements() function is quite right - it is only returning True for sure if ALL of the initial cutType and CutSize checks fail, and it checks no measurements at all, in other words if any if the lines that look like ElseIf Me.TxtCutType = "Hex" And Me.txtcutsize = "0.063" Then are true, then you cannot be sure what the function returns.
The logic in it seems ok to me.

It's an easy fix - just initialize the return value with Checkmeasurements = True before all the checks, and it will only return False if it encounters an error.

You might also want to explicitly declare the type of the function: Private Function checkmeasurements() as boolean

You can make your btnSaveandExit_Click much simpler :


Private Sub btnSaveandExit_Click()
If checkmeasurements Then
Call saveandexitfcn End If
End Sub


The way you had it before it was calling checkmeasurements twice.

HTH

John