No-So-Random Number

[oleBucky]

I am using Rnd() to generate a random number between 1 and 50 for a gaming database project I am working on. The code is activated by a Click event on a command button then the resulting value is passed to a text box for display. I added a "roll" simulator to loop through the numbers to try to give some "body" to a simple click. The problem is that every time the button is clicked after first opening the database the result is 36. It makes me loose faith in the pseudo-random nature of Rnd() if the recurring 36 is not the result of my neophyte coding. Might someone review this code and help me understand this phenomenon?

Let it be known, the Click event controls several other features of the form. However, for the sake of brevity, I am including the following code that applies to the function in question:

Private Sub cmdRandomGame_Click()
    Dim GameNum As String
    Dim RollSim As String
    Dim WAIT As Double
    GameNum = (1 + Int(50 * Rnd()))
    'Use this to test
    'GameNum = 13
    'Trying to make random number change "visible" to user
    RollSim = GameNum + 1
    Do Until RollSim = GameNum
        If RollSim > 50 Then
            If GameNum = 1 Then
                RollSim = 1
            Else
            RollSim = 1
            Me.txtRandomCard = RollSim
            WAIT = Timer
                While Timer < WAIT + 0.01
                DoEvents  'do nothing
                Wend
            RollSim = RollSim + 1
            End If
        Else
            Me.txtRandomCard = RollSim
            WAIT = Timer
                While Timer < WAIT + 0.01
                DoEvents  'do nothing
                Wend
            RollSim = RollSim + 1
        End If
    Loop
    
    Me.txtRandomCard = GameNum
    
End Sub

As always, thanks in advance to the forum for your input.

[RuralGuy]

You have to use Randomize() to set the random seed first.

[pbaldy]

Read up on Rnd() in VBA Help. Rnd() works hand-in-hand with the Randomize statement, which you haven't used. I wrote a little payroll lottery program for someone, and tested it extensively. Used correctly, Rnd() will truly return a random number.

[pbaldy]

Geez, talk about your slow typist!

[RuralGuy]

We have to type fast to keep warm here.

[oleBucky]

A quick clarification... I changed my CP after initializing this thread. I am now using Access 2010 Version 14 32-bit.

In an overall sense, that worked perfectly. However, when entering "Randomize()" in VBA the software gave me a compile error ("Expected: ="). Using "Randomize" only worked. Is this something that will bite me later?

Another quick addition. I would assume it is necessary to "Randomize" each command button generating random number (I have several). Is that assumption correct?

[RuralGuy]

I've not used it before so Paul would be the authority in this thread; even if he is a bit slow in typing.

[boblarson]

A quick clarification... I changed my CP after initializing this thread. I am now using Access 2010 Version 14 32-bit.

In an overall sense, that worked perfectly. However, when entering "Randomize()" in VBA the software gave me a compile error ("Expected: ="). Using "Randomize" only worked. Is this something that will bite me later?

Another quick addition. I would assume it is necessary to "Randomize" each command button generating random number (I have several). Is that assumption correct?

With functions - unless you have something on the left that you are setting equal to (=) you don't use the parens on the function. So by itself you use simply

Randomize

[oleBucky]

Thanks to all! Another step forward in learning for me.