Runtime Error '3061': Too few parameters, Expected 32

[Thompyt]

When I use this Update query in Access it updates the fields in the table:

UPDATE QryCostDiff LEFT JOIN TblActCosts ON QryCostDiff.CON_ID = TblActCosts.ActCON_ID SET TblActCosts.ActGNDTVL = [Forms]![FrmCostDifferences].[ActGNDTVL], TblActCosts.ActTDYStart = [Forms]![FrmCostDifferences].[ActTDYStart], TblActCosts.ActTDYStop = [Forms]![FrmCostDifferences].[ActTDYStop], TblActCosts.ActPDLodge = [Forms]![FrmCostDifferences].[ActPDLodge], TblActCosts.ActLodgeTTL = [Forms]![FrmCostDifferences].[ActLodgeTTL], TblActCosts.ActLodgeTax = [Forms]![FrmCostDifferences].[ActLodgeTax], TblActCosts.ActLodgeWTaxTTL = [Forms]![FrmCostDifferences].[ActLodgeWTaxTTL], TblActCosts.ActPDMeal = [Forms]![FrmCostDifferences]![ActPDMeal], TblActCosts.ActMealTTL = [Forms]![FrmCostDifferences].[ActMealTTL], TblActCosts.ActRent_Type = [Forms]![FrmCostDifferences].[ActRent_Type], TblActCosts.ActRCost = [Forms]![FrmCostDifferences].[ActRCost], TblActCosts.ActFuel = [Forms]![FrmCostDifferences].[ActFuel], TblActCosts.ActRentTTL = [Forms]![FrmCostDifferences]![ActRentTTL], TblActCosts.ActRentTaxTTL = [Forms]![FrmCostDifferences].[ActRentTaxTTL], TblActCosts.ActRentTtlWTax = [Forms]![FrmCostDifferences].[ActRentTtlWTax], TblActCosts.ActBkFee = [Forms]![FrmCostDifferences].[ActBkFee], TblActCosts.ActH2AIRTTL = [Forms]![FrmCostDifferences].[ActH2AIRTTL], TblActCosts.ActAirPark = [Forms]![FrmCostDifferences].[ActAirPark], TblActCosts.ActCarrier = [Forms]![FrmCostDifferences].[ActCarrier], TblActCosts.ActAirfare = [Forms]![FrmCostDifferences].[ActAirfare], TblActCosts.ActBagNum = [Forms]![FrmCostDifferences].[ActBagNum], TblActCosts.ActBagCost = [Forms]![FrmCostDifferences].[ActBagCost], TblActCosts.ActExcessBagCost = [Forms]![FrmCostDifferences].[ActExcessBagCost], TblActCosts.ActBag = [Forms]![FrmCostDifferences].[ActBag], TblActCosts.ActTolls = [Forms]![FrmCostDifferences].[ActTolls], TblActCosts.ActTvlTTL = [Forms]![FrmCostDifferences].[ActTvlTTL], TblActCosts.ActOtherTTL = [Forms]![FrmCostDifferences].[ActOtherTTL], TblActCosts.ActLegTTL = [Forms]![FrmCostDifferences].[ActLegTTL], TblActCosts.ActTTLEWWHrs = [Forms]![FrmCostDifferences].[ActTTLEWWHrs], TblActCosts.ActODCCost = [Forms]![FrmCostDifferences].[ActODCCost], TblActCosts.ActTitels = [Forms]![FrmCostDifferences].[ActTitels]
WHERE (((TblActCosts.ActCON_ID)=[Forms]![FrmCostDifferences].[ActCON_ID]));

Yet when I put this in VBA so that I don't have to select and open a query and it stays hidden

    CurrentDb.Execute "UPDATE QryCostDiff LEFT JOIN TblActCosts ON QryCostDiff.CON_ID = TblActCosts.ActCON_ID SET " & _   
     "TblActCosts.ActGNDTVL = [Forms]![FrmCostDifferences].[ActGNDTVL], TblActCosts.ActTDYStart = [Forms]![FrmCostDifferences].[ActTDYStart], " & _
    "TblActCosts.ActTDYStop = [Forms]![FrmCostDifferences].[ActTDYStop], TblActCosts.ActPDLodge = [Forms]![FrmCostDifferences].[ActPDLodge], " & _
    "TblActCosts.ActLodgeTTL = [Forms]![FrmCostDifferences].[ActLodgeTTL], TblActCosts.ActLodgeTax = [Forms]![FrmCostDifferences].[ActLodgeTax], " & _
    "TblActCosts.ActLodgeWTaxTTL = [Forms]![FrmCostDifferences].[ActLodgeWTaxTTL], TblActCosts.ActPDMeal = [Forms]![FrmCostDifferences]![ActPDMeal], " & _
    "TblActCosts.ActMealTTL = [Forms]![FrmCostDifferences].[ActMealTTL], TblActCosts.ActRent_Type = [Forms]![FrmCostDifferences].[ActRent_Type], " & _
    "TblActCosts.ActRCost = [Forms]![FrmCostDifferences].[ActRCost], TblActCosts.ActFuel = [Forms]![FrmCostDifferences].[ActFuel], " & _
    "TblActCosts.ActRentTTL = [Forms]![FrmCostDifferences]![ActRentTTL], TblActCosts.ActRentTaxTTL = [Forms]![FrmCostDifferences].[ActRentTaxTTL], " & _
    "TblActCosts.ActRentTtlWTax = [Forms]![FrmCostDifferences].[ActRentTtlWTax], TblActCosts.ActBkFee = [Forms]![FrmCostDifferences].[ActBkFee], " & _
    "TblActCosts.ActH2AIRTTL = [Forms]![FrmCostDifferences].[ActH2AIRTTL], TblActCosts.ActAirPark = [Forms]![FrmCostDifferences].[ActAirPark], " & _
    "TblActCosts.ActCarrier = [Forms]![FrmCostDifferences].[ActCarrier], TblActCosts.ActAirfare = [Forms]![FrmCostDifferences].[ActAirfare], " & _
    "TblActCosts.ActBagNum = [Forms]![FrmCostDifferences].[ActBagNum], TblActCosts.ActBagCost = [Forms]![FrmCostDifferences].[ActBagCost], " & _
    "TblActCosts.ActExcessBagCost = [Forms]![FrmCostDifferences].[ActExcessBagCost], TblActCosts.ActBag = [Forms]![FrmCostDifferences].[ActBag], " & _
    "TblActCosts.ActTolls = [Forms]![FrmCostDifferences].[ActTolls], TblActCosts.ActTvlTTL = [Forms]![FrmCostDifferences].[ActTvlTTL], " & _
    "TblActCosts.ActOtherTTL = [Forms]![FrmCostDifferences].[ActOtherTTL], TblActCosts.ActLegTTL = [Forms]![FrmCostDifferences].[ActLegTTL], " & _
    "TblActCosts.ActTTLEWWHrs = [Forms]![FrmCostDifferences].[ActTTLEWWHrs], TblActCosts.ActODCCost = [Forms]![FrmCostDifferences].[ActODCCost], " & _
    "TblActCosts.ActTitels = [Forms]![FrmCostDifferences].[ActTitels] " & _
    "WHERE (((TblActCosts.ActCON_ID)=[Forms]![FrmCostDifferences].[ActCON_ID]));"

I get "Runtime Error '3061': Too few parameters, Expected 32"



ActCON_ID is numerical

I changed "WHERE (((TblActCosts.ActCON_ID)=[Forms]![FrmCostDifferences].[ActCON_ID]));" to "WHERE TblActCosts.ActCON_ID= """ & [Forms]![FrmCostDifferences].[ActCON_ID] & ";"""
then I get "Runtime Error '3061': Too few parameters, Expected 31"

Am I getting the concatenation incorrect?

[Minty]

Put the concatenation into a string variable and debug.print it in the code before the execute.

strSQL = " blah blah blah"
Debug.Print strSQL

The resulting string should make it obvious where the problem is.
If you can't see it paste it into the query designer SQL window and switch to design view and then it should be more obvious.

If you still can't see the problem post the result here and someone might be able to spot it.

EDIT - Just noticed you aren't concatenating the form variables. VBA doesn't understand the Form! references.

You'll need to do something like

    "TblActCosts.ActGNDTVL = " & [Forms]![FrmCostDifferences].[ActGNDTVL] & ",  TblActCosts.ActTDYStart = " & [Forms]![FrmCostDifferences].[ActTDYStart] & ", " & _

The above assumes numeric values, text values will need delimiting with single quotes or treble double quotes, Dates formatted with hashes as a delimiter : #yyyy-mm-dd#

[Welshgasman]

Why not use a bound form?

[CJ_London]

assign your sql to a string and debug.print it - that is standard development practice

dim sqlstr as string

sqlstr="UPDATE QryCostDiff LEFT JOIN........" 
debug.print sqlstr
'now copy the string from the immediate window to a new query and try to execute it or compare with your original query
currentdb.execute sqlstr

[Minty]

@CJ That is also my normal modus operandi however if the string comes out with all the forms references, instead of failing in the normal query window it will probably work.

Hopefully we might hear back from the OP.

[CJ_London]

@minty - sorry - didn't see your post until after I posted mine!