Alternate methods to filter results and which is better ??

[ScubaBart]

On the path to convert all my macros over to VBA since getting help on macros is painful and have come up with a couple different ways to filter my results when opening the next form.

I used various examples found online and also looked at the code crated when I converted macros to code on a copy of my database. So I have two ways to filter my results:

One

    DoCmd.OpenForm "F_Log_Apiary_Main", acNormal, "", , , acNormal
    DoCmd.ApplyFilter , "Active = -1 And [Log_Apiary_ID] > 1"

and Two

    DoCmd.OpenForm "F_Log_Apiary_Main", acNormal, "Active = -1 And [Log_Apiary_ID] > 1", , , acNormal

Is one better than the other or one preferred over the other and if so, why ?

Is there a better way than either of these methods ?


Just asking so I can gain a better understanding as I create additional code with more efficiency.

Thanks.....

[June7]

The end results of both versions are the same.

Why have two lines of code executing two commands when one will serve?

Use OpenForm and its argument to apply filter when opening another form.

Use ApplyFilter when desire is to filter same form code is behind.

Note, your second version is using wrong argument to pass filter criteria.
And what is purpose of second acNormal?

DoCmd.OpenForm "F_Log_Apiary_Main", acNormal, , "Active = -1 And [Log_Apiary_ID] > 1"

[Micron]

IMO they are virtually the same thing, esp. if they both provide the desired result. Those 2 methods are not the only ways either. One can open a form then set the filter property, then turn the filter on. That may be more useful if you wish to maintain a filter but cycle it on and off. Even then, you can do this from the calling form or the called form. You can also set the filter property in the property sheet if that ever makes sense.

I wouldn't worry too much about maximizing efficiency just yet. What you might consider is to create and post for comments related to efficiency. One tip I can pass on at this time would be that certain methods have defaults and you don't need to write them out (based on you post you can drop all those parameters and it shouldn't matter). I can recommend this site for guidance, but sometimes the problem is that you need a modicum of knowledge to be able to find what you're looking for.

[ScubaBart]

Note, your second version is using wrong argument to pass filter criteria.
And what is purpose of second acNormal?

DoCmd.OpenForm "F_Log_Apiary_Main", acNormal, , "Active = -1 And [Log_Apiary_ID] > 1"

This is probably where I used the format from where I converted macros to VBA. It seems to put in a lot of stuff that apparently isn't really required. I had wondered why it was there but didn't mess with it not knowing any better.


I will also research the reference that Micron linked to. Thanks.

[moke123]

I had the same thought as micron regarding the defaults for various arguments in a method.
I'm sure you've noticed Intellisense when your using the VBA editor.

You'll notice below that FormName is a required argument.(no brackets)
The rest of the arguments have brackets [ ] around them which indicates they are optional.



Those optional arguments that have an "= something" are the default values for those arguments.
Intellisense will show you the other possible values as you move through the arguments.