Create a list of images for email

**DMT Dave** · 01-08-2023, 03:19 AM

Hi Guy's, i need a little help on this one please ?

I have spent a while trying different things to make this work!!!!

I am looping files to go to email, the result of the list is correct in the Imm window (5 files in the folder)

I dont' think i can generate a loop with in the email html body ?

I can very easily open 5 emails by moving the loop to after email but my target is to have 1 x email with all 5 images on

ie:
table & image1
<br>
table & image2
<br>
table & image3
etc etc....

on this occasion the 5 images in the folder

Once email generated, the files will get moved to another folder so there isn't an overload of images to open/send

Code:

sPath = "T:\DMT Ltd\Cam Images\"sFiles = Dir(sPath & "*.jpg")


Do While Len(sFiles) > 0
        i = i + 1
        
        sFileList = sFiles
        sFiles = Dir()


        
        strEmailImages = sFileList
        
        Debug.Print sPath & sFileList
        'Imm Window showing 5 files
Loop
    
    
    Set myItem = myApp.CreateItem(olMailItem)
    Set OutAccount = myApp.Session.Accounts.Item(1)
    With myItem
    .To = ""
    .subject = "Images"
    .HTMLBody = Replace(TOD, "|", "<br>") & "<br>" & "<br>" & _
    "Please find images we have taken, " & "<br>" & "<br>" & _
    strEmailImages & "<br>" & "<br>" & _
    strTableStart & "<br>" & _
    "<P><IMG border=2 hspace=0 alt='' src='file:" & sPath & sFileList & "' align=baseline></P>" & "<br>" & strTableEnd & _
    KR & "<br>" & "<br>" & _
    FName & "<br>" & "<br>" & _
    "<P><IMG border=0 hspace=0 alt='' src='file://T:/DMT Ltd/Logo Media/" & SigFile & "' align=baseline></P>" & "<br>" & "<br>" & _
    "<FONT color=#00008B>" & eDisc & "<br>" & "<FONT color =#00008B>" & eDisc2
    .SendUsingAccount = OutAccount
    .Display
    End With

**Welshgasman** · 01-08-2023, 04:48 AM

I dont' think i can generate a loop with in the email html body ?

Why not. I did just that to add records to a html table when I used to send emails.

**DMT Dave** · 01-08-2023, 05:55 AM

WGM thank you, so I should add a loop inside the HTML

start loop just before tablestart and end the loop after table end ?

i will try that

**DMT Dave** · 01-08-2023, 07:27 AM

I have tried adding a for loop within the file count to see if i can get the number of tables and images onto the mail body!

it all adds up as there is x 5 images in the folder but struggling to loop them onto the mail body!!!

Code:

sPath = "T:\DMT Ltd\Cam Images\"sFiles = Dir(sPath & "*.jpg")


Set fso = CreateObject("Scripting.FileSystemObject")
   
    Set objFiles = fso.GetFolder(sPath).Files
   
    intFiles = objFiles.Count - 1
   
    MsgBox intFiles     'Total number of files


Do While Len(sFiles) > 0
        i = i + 1
        
        sFileList = sFiles
        sFiles = Dir()
        
        For x = 1 To intFiles
        
        strTableStart = "<table style='text-align:left;border:3px solid blue;font-family:calibri;border-collapse:collapse;padding:25px'><tr style='background:white;mso-highlight:blue'>"
        
            strEmailImages = sPath & sFileList
        
        strTableEnd = "</tr></table>"
        
        Next x
        
        Debug.Print sPath & sFileList
        'Imm Window showing 5 files
Loop
    
    ' ORHGINAL FILE SOURCE "<P><IMG border=2 hspace=0 alt='' src='file:" & sPath & sFileList & "' align=baseline></P>"
    
    Set myItem = myApp.CreateItem(olMailItem)
    Set OutAccount = myApp.Session.Accounts.Item(1)
    With myItem
    .To = ""
    .subject = "Images"
    .HTMLBody = Replace(TOD, "|", "<br>") & "<br>" & "<br>" & _
    "Please find images we have taken, " & "<br>" & "<br>" & _
    strEmailImages & "<br>" & "<br>" & _
    strTableStart & "<br>" & _
    "<P><IMG border=2 hspace=0 alt='' src='file:" & sPath & strEmailImages & "' align=baseline></P>" & "<br>" & strTableEnd & _
    KR & "<br>" & "<br>" & _
    FName & "<br>" & "<br>" & _
    "<P><IMG border=0 hspace=0 alt='' src='file://T:/DMT Ltd/Logo Media/" & SigFile & "' align=baseline></P>" & "<br>" & "<br>" & _
    "<FONT color=#00008B>" & eDisc & "<br>" & "<FONT color =#00008B>" & eDisc2
    .SendUsingAccount = OutAccount
    .Display
    End With

**Welshgasman** · 01-08-2023, 07:44 AM

I have not played around much with HTML, but surely there should only be one <table >and </table>

Think about what you are trying to do.

Get it working for 1 file, then proceed with the loop. You can loop 1 to 1 you know?

Attached is how I did mine. I have given you the whole code, so you will need to pick out what you need, but just inspect it. There are a few comments in there.

**Minty** · 01-08-2023, 09:13 AM

Dave, to reinforce what WGM is saying - and if you don't mind me saying you do seem to struggle with loops in general so, spilt the task into big logical steps first.
Ignore the detail and how, just outline the process. On paper if necessary, and follow it through.

So, you want to email a number of images into one email.
Big points are (and in this order):

Open a New Email
Create the Email header and one of detail (Subject etc)
Create a Table
Loop to Insert Table rows
Finish the Loop
Create the Email Ending
Send the email

It's simple really, If you map out your current process in the same way you will see the flaw in the middle section points 3 & 4.

Open a New Email
Create the Email header and one of detail (Subject etc)
Loop to Insert rows
Create a Table
Finish the loop
Create the Email Ending
Send the email

Does that help?

**DMT Dave** · 01-08-2023, 10:43 AM

Thanks Guy's i can get it going for 1 file but can't seem the get the array of files will read through what you have both suggested

**June7** · 01-08-2023, 09:13 PM

Not clear to me what you want. You want each image in its own table? Why? Is there other data? Don't need HTML table structure just to display images in email.

Why do you concatenate strEmailImages for .HTMLBody twice?

Perhaps you could do a mockup in Excel of how you want this email to appear.

As advised, work it out in steps. Start with basic and expand. Get a simple loop working first. Consider:

Code:

Dim strPath As String, strFile As String, strEmailImages As String
Dim appOutLook As Outlook.Application
Dim MailOutLook As Outlook.MailItem

Set appOutLook = New Outlook.Application
Set MailOutLook = appOutLook.CreateItem(olMailItem)

strPath = "T:\DMT Ltd\Cam Images\"
strFile = Dir(strPath & "*.jpg")
Do While strFile <> ""
    strEmailImages = strEmailImages & "<IMG src= " & strPath & strFile & " width=100 height=100><br>"
    strFile = Dir
Loop

With MailOutLook
    .To = "some address"
    .Subject = "Some Subject"
    .HTMLBody = "Please find images we have taken:<br>" & strEmailImages
    .Display
End With

Modifed to use table and row structure:

Code:

strTableStart = "<table style='text-align:left;border:3px solid blue;font-family:calibri;border-collapse:collapse;padding:5px'>"
strIntro = "<tr style='background:white;mso-highlight:blue'>Please find images we have taken: </tr>"
strTableEnd = "</table>"

With MailOutLook
    .To = "some address"
    .Subject = "Some Subject"
    .HTMLBody = strTableStart & strIntro & strTableEnd & strEmailImages
    .Display
End With

Alternative is to zip images to Windows Compression folder and attach to email.

**DMT Dave** · 01-09-2023, 12:41 AM

Thank you, yes it is to have each image in it's own table and yes to insert the images into 1 email

I can see its mainly the procedure where i am going wrong and where the loop is initiated

**June7** · 01-09-2023, 01:01 AM

I just noticed title of thread says "list of images" but your code is actually to embed images in email. Which do you really want?

I don't understand why each image needs to be in separate table. But if you must:

Code:

strTableStart = "<table style='text-align:left;border:3px solid blue;font-family:calibri;border-collapse:collapse;padding:5px'>"

strPath = "T:\DMT Ltd\Cam Images\"
strFile = Dir(strPath & "*.jpg")
Do While strFile <> ""
    strEmailImages = strEmailImages & strTableStart & "<tr><IMG src= " & strPath & strFile & " width=100 height=100></tr></table>"
    strFile = Dir
Loop

strIntro = strTableStart & "<tr style='background:white;mso-highlight:blue'>Please find images we have taken:</tr></table>"

With MailOutLook
    .To = "some address"
    .Subject = "Some Subject"
    .HTMLBody = strIntro & strEmailImages
    .Display
End With

**DMT Dave** · 01-09-2023, 01:40 AM

Hi June7, thank you, this is my modified version, i am just trying to have each file with it's own filename excluding .jpg within the table

Nearly there with this now thank you

Code:

sPath = "T:\DMT Ltd\Cam Images\"sFiles = Dir(sPath & "*.jpg")




    Set myItem = myapp.CreateItem(olMailItem)
    Set OutAccount = myapp.Session.Accounts.Item(1)
    With myItem


Do While sFiles <> ""
    
    strList = strList & sFiles & ";" ' to get file names
    
        Me.lstFiles.RowSource = strList 'populate list
        
        For i = 1 To Me.lstFiles.ListCount - 1
        
            strFileNames = strFileNames & Me.lstFiles.Column(0, i)
            
        Next
        
    strEmailImages = strEmailImages & _
        "<table style='text-align:left;border:3px solid blue;font-family:calibri;border-collapse:collapse;padding:5px'><br>" & _
            Replace(strFileNames, ".jpg", "") & _
            "<P><IMG border=2 hspace=0 alt='' src='file:" & sPath & sFiles & "' align=baseline></P>" & "<br>" & _
        "</table><br>"
    
    sFiles = Dir
    
Loop


strIntro = "Please find images we have taken:"


    .To = "some address"
    .subject = "Some Subject"
    .HTMLBody = strTableStart & strIntro & strTableEnd & strEmailImages
    .Display
End With

**June7** · 01-09-2023, 02:42 AM

And what happens when you run that? I doubt what you want. I think you just moved farther away from your goal.

The filename without .jpg can be obtained from the filename of file referenced in folder. So why is a listbox now involved?

You need to clarify exactly what you are trying to accomplish.

Again, I suggest you provide a mockup of what this output should look like.

**DMT Dave** · 01-09-2023, 02:52 AM

Hi June7, i tried adding a list box to retrieve the file names then each table will have a file name and image

I didn't know i can retrieve file names without a listbox ? it's the only method I have ever used in the past so I was using a method i know!

If that can be don without the need for listing the file names, i would do it just to shorten and tidy up

**DMT Dave** · 01-09-2023, 02:53 AM

All works to what the initial target was though, to add the images to the mail body, thanks to your suggestions

**June7** · 01-09-2023, 03:09 AM

You are retrieving file names with code that loops through folder. Just truncate. If you know every file will have .jpg extension, it's simple.

Code:

Do While strFile <> ""
    strEmailImages = strEmailImages & Replace(strFile, ".jpg","") & strTableStart & "<tr><IMG src= " & strPath & strFile & " width=100 height=100></tr></table>"
    strFile = Dir
Loop

This does assume nowhere else in file name is substring ".jpg".

Create a list of images for email

Thread Tools

Create a list of images for email

Similar Threads

Looking to Create an Email button based on a list criteria

Display Linked Multiple Images in a subform with a tab as navigatable images. ACCESS 2007

Has anyone worked with hypelinks vs actual images as Attachments in Access dB to create PDFs?

Why does my send to email button create this in TO: Email A.com#mailto: Email@.com#

Create a Recipient List and add to 'To' line in blank email msg?

Posting Permissions