Before_Update event prevents me from saving

[Chrtalgo]

Hi!


I am struggeling to save an edited record.


This is my save button:

Private Sub SaveButton_Click()

    Dim SaveButtonUsed As Boolean
    SaveButtonUsed = True


    DoCmd.RunCommand acCmdSaveRecord


    MsgBox "Saved!"
    Me.SaveButton.Enabled = False 'Only enabled after pressing Edit button
    
    Me.AllowEdits = False
    Me.AllowAdditions = False

End sub

I use this code to prevent any save unless SaveButton is clicked:

Private Sub Form_BeforeUpdate(Cancel As Integer)
If SaveButtonUsed = False Then
Me.Undo


End If




End Sub

Somehow the before update event prevents the savebutton from working. It works if I leave out this last code.


Why is this, and what will fix it?

[orange]

What exactly are you trying to do--in simple non database terms?
Access will save a record when you move to another record.
BeforeUpdate is the last event where you can make edits or reject same before a record is saved.

You may get more detailed info re form/control events here.

[Chrtalgo]

Hi, Orange!

I want the before update event to discard any changes to the record, if the save button haven’t been pressed.

That is why I use the Boolean on «SaveButtonUsed».

If save button is used, it should, as far as I can see toggle the «SaveButtonUsed» to true, and thus bypass the me.undo on the form_before_update event.

I can also add that on form_current me.allowedits and me.allowadditions is set to false, and are toggled to true via a Edit button.


If I don’t code the before_update part, I can press edit and perform changes, which is saved when I press the save button, or if I navigate to a different record, close the form etc.

I want to prevent save and discard changes on all actions other than pressing save button. But this current before_update event is prevent the saving all together. It seems to me that the boolean SaveButtonUsed is either not correctly set by the savebutton_click, or the before_update is treating it as false regardless of what it has been set to.

Pressing save should set SaveButtonUsed = True, and then the before_update code should let it pass. But it doesn’t...

[orange]

See this link from ghudson re BeforeUpdate validation

[John_G]

You have declared SaveButtonUsed in the Save Button click procedure (Dim SaveButtonUsed As Boolean), which means that SaveButtonUsed is known ONLY to that procedure. BeforeUpdate doesn't recognize it. To fix that, move Dim SaveButtonUsed As Boolean to the top of the module, in the declarations section, before any of the subs.

You should also have Option Explicit in EVERY code module; that would have caught your error because the code would not compile (undeclared variable error)

[ranman256]

put it in Afterupdate

[Chrtalgo]

You have declared SaveButtonUsed in the Save Button click procedure (Dim SaveButtonUsed As Boolean), which means that SaveButtonUsed is known ONLY to that procedure. BeforeUpdate doesn't recognize it. To fix that, move Dim SaveButtonUsed As Boolean to the top of the module, in the declarations section, before any of the subs.

You should also have Option Explicit in EVERY code module; that would have caught your error because the code would not compile (undeclared variable error)

Thank you!