If Statement Not Working

[conradqb]

Hi,



I've got a if statement that doesn't work. The second part (the elseif statement) works fine, but even if I run the first part on its own, it doesn't want to work.

Private Sub cb_intercompany_code_AfterUpdate()

    If cb_customer_grp_code.Value = "INTERCO" And IsNull(cb_intercompany_code) = True Then
    
        MsgBox "You must complete an intercompany code when the customer grp code = INTERCO"
        Me.cb_intercompany_code.SetFocus
    
    ElseIf cb_customer_grp_code.Value <> "INTERCO" And IsNull(cb_intercompany_code) = False Then
    
        MsgBox "You cannot complete an intercompany code when the customer grp code is not INTERCO"
        Me.cb_intercompany_code.SetFocus
        Me.cb_intercompany_code = Null
    
    End If


End Sub

Any ideas as to why this might be?

[nick404]

Get rid of .Value after cb_customer_grp_code ?

[ItsMe]

Which line does it halt on when you debug?

Is it this one?
Me.cb_intercompany_code.SetFocus

Maybe the cb_intercompany_code control is not available to receive focus.

[June7]

What happens - error message, wrong results, nothing?

Should probably use BeforeUpdate event for data validation.

[Rawb]

As a general rule, I'd recommend adding the prefix "Me!" to your Form Control references. If nothing else, it can help ease confusion when looking at individual code blocks by telling you, at a glance, if something is a Form Control or not.

Also, IsNull() isn't guaranteed to return what you want (for example, the empty string "" does not evaluate to null). I'd recommend checking the length instead:

Len(Me!cb_intercompany_code & vbNullString) = 0

It's a little clunkier-looking, but in my experience tends to work more reliably when dealing with user-controlled data.