Please Help Me Fix The Code

[aamer]

The Following Code Is Working Perfectly with number fields.

Please note "LoginIDNo" is Number Field, where as I want to change this to Text Field, e.g David instead of 2 (this is login id of david)
The Text Field I want to use is [EntryPLogin By] How and what changes are required to do this. Help is needed.



Private Sub cmdOpenReportDataop_Click()
On Error GoTo Err_Handler

Const REPORTNAME = "General Purchase wo Varification"
Const MESSAGETEXT = _
"A customer and both a start and end date must be selected."
Dim strCriteria As String
Dim strDateFrom As String, strDateTo As String

' make sure a customer and both dates are selected


If Not IsNull(Me.CboDataOp) And Not IsNull(Me.cboDateFrom) _
And Not IsNull(Me.cboDateTo) Then
strDateFrom = "#" & Format(Me.cboDateFrom, "yyyy-mm-dd") & "#"
strDateTo = "#" & Format(DateAdd("d", 1, Me.cboDateTo), "yyyy-mm-dd") & "#"
' build string expression to filter report
' to selected customer and data range
strCriteria = "LoginIDNo = " & Me.CboDataOp & _
" And PurDate >= " & strDateFrom & " And PurDate < " & strDateTo

' open report filtered to selected customer and date range
DoCmd.OpenReport REPORTNAME, _
View:=acViewPreview, _
WhereCondition:=strCriteria
Else
MsgBox MESSAGETEXT, vbExclamation, "Invalid operation"
End If

Exit_Here:
Exit Sub

Err_Handler:
MsgBox Err.Description, vbExclamation, "Error"
Resume Exit_Here
End Sub

[June7]

Filter parameters for text fields need apostrophe delimiters.

"[EntryPLogin By]='" & Me.tbxLogin & "'"

Date fields use the # character as delimiter.

[aamer]

Please note the name of table: Purchases & Query: Pchase (I am mentioning this is required by you)

I tried the following by replacing
strCriteria = "LoginIDNo = " & Me.CboDataOp & _

with

strCriteria = "[EntryPLogin By]='" & Me.tbxLogin & "'"


its giving me errors.







Private Sub cmdOpenReportDataop_Click()

On Error GoTo Err_Handler
Const REPORTNAME = "General Purchase wo Varification"
Const MESSAGETEXT = _
"A customer and both a start and end date must be selected."
Dim strCriteria As String
Dim strDateFrom As String, strDateTo As String
' make sure a customer and both dates are selected
If Not IsNull(Me.CboDataOp) And Not IsNull(Me.cboDateFrom) _
And Not IsNull(Me.cboDateTo) Then
strDateFrom = "#" & Format(Me.cboDateFrom, "yyyy-mm-dd") & "#"
strDateTo = "#" & Format(DateAdd("d", 1, Me.cboDateTo), "yyyy-mm-dd") & "#"
' build string expression to filter report
' to selected customer and data range
strCriteria = "[EntryPLogin By]='" & Me.tbxLogin & "'"
" And PurDate >= " & strDateFrom & " And PurDate < " & strDateTo
' open report filtered to selected customer and date range
DoCmd.OpenReport REPORTNAME, _
View:=acViewPreview, _
WhereCondition:=strCriteria
Else
MsgBox MESSAGETEXT, vbExclamation, "Invalid operation"
End If
Exit_Here:
Exit Sub
Err_Handler:
MsgBox Err.Description, vbExclamation, "Error"
Resume Exit_Here
End Sub

[John_G]

You are missing a "&" and the continuation character at the end of the line. Change it to:

strCriteria = "[EntryPLogin By]='" & Me.tbxLogin & "'" & _

John

[aamer]

its not working

what is tbxlogin means??

[John_G]

Where on your form is the Login Name that you want to use? Is it a column of the combo box Me.CboDataOp ?

You want to refer to that instead of using Me.tbxLogin .

[aamer]

finally I figured it out.

thanks June & John_G for your help



I am using the following code, please check if you think there are any errors in code. Although its working fine.


Private Sub cmdOpenReportDataop_Click()
On Error GoTo Err_Handler

Const REPORTNAME = "General Purchase wo Varification"
Const MESSAGETEXT = _
"A customer and both a start and end date must be selected."
Dim strCriteria As String
Dim strDateFrom As String, strDateTo As String

' make sure a customer and both dates are selected
If Not IsNull(Me.CboDataOp) And Not IsNull(Me.cboDateFrom) _
And Not IsNull(Me.cboDateTo) Then
strDateFrom = "#" & Format(Me.cboDateFrom, "yyyy-mm-dd") & "#"
strDateTo = "#" & Format(DateAdd("d", 1, Me.cboDateTo), "yyyy-mm-dd") & "#"
' build string expression to filter report
' to selected customer and data range

strCriteria = "[EntryPLogin By]='" & Me.CboDataOp & "'" & _
" And PurDate >= " & strDateFrom & " And PurDate < " & strDateTo

' open report filtered to selected customer and date range
DoCmd.OpenReport REPORTNAME, _
View:=acViewPreview, _
WhereCondition:=strCriteria
Else
MsgBox MESSAGETEXT, vbExclamation, "Invalid operation"
End If

Exit_Here:
Exit Sub

Err_Handler:
MsgBox Err.Description, vbExclamation, "Error"
Resume Exit_Here
End Sub