Blank String

[DMT Dave]

Hi Guy's what am I doing wrong here, I am trying to get either Forename only (Joe) or if the title <> "" then I am trying to get title and surname (Mr Bloggs)

The MsgBox is blank

Dim MyStr As String, fName As String, SName As String, mHello as String
If Me.txtClientName <> "" Then
If Me.cboClientTitle = "" Then
MyStr = InStr(Me.txtClientName, " ")
fName = Left(Me.txtClientName, MyStr) 'Forename
SName = Right(MyStr, MyStr) 'Surname
mHello = fName
Else
fName = ""
SName = ""
End If
End If
If Me.txtClientName <> "" Then
If Me.cboClientTitle <> "" Then
MyStr = InStr(Me.txtClientName, " ")
fName = Left(Me.txtClientName, MyStr) 'Forename
SName = Right(MyStr, MyStr) 'Surname
mHello = Me.cboClientTitle & " " & SName
Else
fName = ""
SName = ""
End If
End If
MsgBox (mHello)

[June7]

Code would be easier to read with indentation.

Repeating If conditions is not logical.

More likely an empty field is Null, not an empty string, so handle both possibilities.

InStr() returns a number, not a string.

MsgBox with parens is a function returning a value. For a popup message that user just closes, don't need parens, although looks like will work.

Consider:

Dim strName As String
strName = Nz(Me.txtClientName, "")
If strName <> "" Then
    If Me.cboClientTitle & "" = "" Then
        MsgBox Left(strName, InStr(strName, " ")) 'Forename
    Else
        MsgBox Me.cboClientTitle & Mid(strName, InStr(strName, " ")) 'Title and Surname
    End If
End If

Name parts really should be separate fields in table.