How to add an error handling code to Select Case statements?

[JennyL]

Hi

I am trying to add an error handling code to Select Case, but not sure where to add. I have error handling for on click but don't seem it works on Select Case below. B

Below is a short version of my Select Case VBA. I have case up to 30 options. Any recommendations on how to add the Error Handling? thanks,

Private Sub Frame109_AfterUpdate()
Dim strFilter As String
Select Case Frame109

Case 0
Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = False
Me.Refresh



Case 1 'this is the radio button option number
strFilter = "[Category] = 1" 'this is ID in the category table

Me.Sfrm_CustomerFeeSchedule.Form.Filter = strFilter
Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = True

Case 2
strFilter = "[Category] = 2"

Me.Sfrm_CustomerFeeSchedule.Form.Filter = strFilter
Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = True

Case 3
strFilter = "[Category] = 3"

Me.Sfrm_CustomerFeeSchedule.Form.Filter = strFilter
Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = True

Case 4
strFilter = "[Category] = 4"


End Select
End Sub

[ranman256]

carve out a block at the bottom to handle the errors.

Private Sub Frame109_AfterUpdate()
Dim strFilter As String
On Error GoTo ErrStop
Select Case Frame109
Case 0
    Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = False
    Me.Refresh
Case 1 'this is the radio button option number
    strFilter = "[Category] = 1" 'this is ID in the category table
    
    Me.Sfrm_CustomerFeeSchedule.Form.Filter = strFilter
    Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = True
Case 2
    strFilter = "[Category] = 2"
    
    Me.Sfrm_CustomerFeeSchedule.Form.Filter = strFilter
    Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = True
Case 3
    strFilter = "[Category] = 3"
    
    Me.Sfrm_CustomerFeeSchedule.Form.Filter = strFilter
    Me.Sfrm_CustomerFeeSchedule.Form.FilterOn = True
Case 4
    strFilter = "[Category] = 4"
End Select
Exit Sub

ErrStop:
    'resumes go here
if err = 13 then
   resume next
else
    MsgBox Err.Description, , Err
endif
End Sub

[Minty]

I'm slightly puzzled what error handling you would need, as surely your case statement caters for all possible options in your option group?

I'm not saying you shouldn't have any error handling, just I can't see how it would ever be called for this event.

[moke123]

couldnt you just use

strFilter = "[Category] = " & Frame109

also with a select case statement you can use a "case else" to catch any unknown values

[JennyL]

couldnt you just use

strFilter = "[Category] = " & Frame109

also with a select case statement you can use a "case else" to catch any unknown values

Does this mean radio option number equals to category number? I will to make sure the two numbers are equal in the future if I end up adding more radio buttons, correct? what will happen if I use "case else"? Will I get a error message?

Thanks,

[Minty]

As Mokes off line - At the end of your Case statements

Case Else 
      MsgBox "You have managed to not choose a sensible option"
End Select

And yes if your option group numbers match then you just need to keep them in line with the filter conditions.

To be honest 30 option buttons is a lot and if you maybe need to redesign to accommodate another potential choice, perhaps not the best route to go.
Maybe a List box or combo that would accommodate any number of choices might be better?