Building a DLookup statement correctly

[Lou_Reed]

In the two db's that I have attached, one works (the smaller db) and one I am working on db (the larger db)



When I am working on the correct functioning db, I come across the lines of code:

 '-- Combo of names to assign ticket to
    stWho = Me.cboAssignee
    stWhere = "tblUsers.strUserID = " & "'" & stWho & "'"
    '-- Looks up email address from TblUsers
    varTo = DLookup("[strEMail]", "tblUsers", stWhere)

Now I will address a couple of things. First, the record source for the form frmEmail is a query qryMeeting_Personnel. So I guess that I will have to substitute when I make out the
stWhere statement on the larger db and put it in quotes. Again there is no table, my record source is qryMeeting_Personel. Now I must also build the varTo statement. So I believe this it should be

varTo = DLookup("email address","qryMeeting_Personnel',stWhere)
provided StWhere was assumed previously defined correctly.

The files of the two dbs one complete and working; that one is a work in progress, are attached.

Please tell me if I did this correctly.

[Bulzie]

Not sure why you have to use all those variables instead of just spelling it out on 1 line:
varTo = DLookup("[strEMail]", "tblUsers", "Where [strUserID] = '" & Me.cboAssignee & "'")

[Lou_Reed]

It is just for readability. I thought breaking it down would simplify the coding. Maybe, I was wrong.

It does not seem to hurt anything, though.

Would not doing it be an improvement or not?

Respectfully,

Lou Reed

[pbaldy]

Not sure why you have to use all those variables instead of just spelling it out on 1 line:
varTo = DLookup("[strEMail]", "tblUsers", "Where [strUserID] = '" & Me.cboAssignee & "'")

That wouldn't work with the word "Where" in it, would it?

@Lou, to me it's personal preference. I wouldn't use the variable for a simple 1 field criteria like this, I would if it gets longer, has more fields, etc.

[Bulzie]

Yes my bad, take the "Where " out. I think it is much easier to read a single line of text with the actual fields instead of reading variables and figuring out what they reference. But as Paul said, you can do it how you like as long as it works how you need.