My code is faulty for disabling command button

[mike_980]

I have a form which navigates through a record set, I have custom navigation buttons, one for "next record" one for "previous record". I have it set so that when the first or last record is reached, one of the buttons disables to prevent the error messages etc.



The problem seems to be with the disabling of the next record button, sometimes it works perfectly but sometimes when I first open the form and click "next record" the button immediately disables itself making the form completely ususable.

here is the section of code that fires when the button is clicked.

Private Sub Command8_Click()

With Recordset
If .AbsolutePosition = .RecordCount - 1 Then
Command8.Enabled = False

Else

DoCmd.GoToRecord , , acNext

End If


If Crop_ID >= 1 Then

Dim Crop_ID_select As String
Me.Combo6.SetFocus
Crop_ID_select = DLookup("Crop", "qry_combo_manage_destinations2")
Me.Combo6 = Crop_ID_select

Else
Me.Combo6.Value = ""


End If
End With
End Sub

[orange]

It might be better if you would attach a copy of your database ---remove anything private/confidential first.

[amrut]

Instead of disabling the button, how about notifying the user ?

Private Sub Command29_Click()
10       On Error GoTo Command29_Click_Error

20    DoCmd.GoToRecord , , acPrevious

30       On Error GoTo 0
40       Exit Sub

Command29_Click_Error:
50    If Err.Number = 2105 Then
60    MsgBox "This is the first record"
70    Else
80        MsgBox "Error Line: " & Erl & vbNewLine & "Error " & Err.Number & " (" & Err.description & ") in procedure Command29_Click of VBA Document Form_Form1"
90    End If
End Sub

Private Sub Command30_Click()
10       On Error GoTo Command30_Click_Error

20    DoCmd.GoToRecord , , acNext

30       On Error GoTo 0
40       Exit Sub

Command30_Click_Error:
50    If Err.Number = 2105 Then
60    MsgBox "This is the last record"
70    Else
80        MsgBox "Error Line: " & Erl & vbNewLine & "Error " & Err.Number & " (" & Err.description & ") in procedure Command30_Click of VBA Document Form_Form1"
90    End If
End Sub

[ItsMe]

I think Access warns the user if DoCmd.GoToRecord does not find the record. You could modify an error trap to give a custom msg.

Also, a recordsetclone and recordcount on the form's current event should work for conditional formatting of your controls.

[mike_980]

Thanks amrut! for some reason I never thought about that method! works perfectly thankyou!

ItsMe- thanks for your input too, that would probably have worked too