error handling

[slimjen]

Hi all,


Taken over a acces 2003 database. Trying to error trap code for updating user info. Without error trap works. When I try to add error trap it errors saying "sub or function not defined". Please help

Private Sub Combo7_AfterUpdate()
'On Error GoTo Err_Combo7_AfterUpdate    ' Find the record that matches the control.
    Dim rs As Object
    Set rs = Me.Recordset.Clone
    rs.FindFirst "[NewPT] = '" & Me![Combo7] & "'"
    If Not rs.EOF Then Me.Bookmark = rs.Bookmark
'Exit_Combo7_AfterUpdate
'    Exit Sub
'Err_Combo7_AfterUpdate:
'    MsgBox Err.Description
'    Resume Exit_Combo7_AfterUpdate
    
End Sub

[JoeM]

Try:

Private Sub Combo7_AfterUpdate()
 
   On Error GoTo Err_Combo7_AfterUpdate 

' Find the record that matches the control. 
    Dim rs As Object 
    Set rs = Me.Recordset.Clone 
    rs.FindFirst "[NewPT] = '" & Me![Combo7] & "'" 
    If Not rs.EOF Then Me.Bookmark = rs.Bookmark

'Exit Combo7_AfterUpdate
    Exit Sub

Err_Combo7_AfterUpdate:
    MsgBox Err.Description

End Sub

[slimjen]

Ok Great! but why did it not like the "exit_Combo.. and Resume.." I always use this.
thanks for your help.

[pbaldy]

You missed the colon after it.


Exit_Combo7_AfterUpdate:

[JoeM]

A few things:

The Message Box is the last step before the end of the sub, so why go back up to a statement that tells it to exit, when it will just exit naturally with the last line of code. It is unnecessary.

But, as for the problems, first for "Exit_Combo7_AfterUpdate" to be a valid point you can jump to, it cannot be commented out and must have a colon at the end, i.e.

Exit_Combo7_AfterUpdate:

Second, you don't use "Resume" to go to another section of code, you use "Resume Next" to pick up where you left off (I don't think you can tell it to go to some other part of your code like that).

You might want to read the section on "Resume" here: http://www.cpearson.com/excel/ErrorHandling.htm. It is written from an Excel perspective, but VBA error handlers work similarly for Excel and Access.

[slimjen]

Great! thanks to you all.

[pbaldy]

The Message Box is the last step before the end of the sub, so why go back up to a statement that tells it to exit, when it will just exit naturally with the last line of code.

Second, you don't use "Resume" to go to another section of code, you use "Resume Next" to pick up where you left off (I don't think you can tell it to go to some other part of your code like that).

The use of Resume to go the exit handler was fine (and was used the same way in the referenced link).

While perhaps not actually necessary here, the line to resume at the exit handler is commonly included since the exit handler often has "clean-up" code in it. Some would argue that it is necessary here, as the rs variable would typically be set to Nothing in the exit handler (the rule of thumb being to clean any variable set with "Set").