Adding A Time Of Day; With Message To Switchboard

[HMEpartsmanager]

Hello All,



In my Switchboard, I have a text box that I change the contents every once in a while. Usually a line or two as a "joke of the day" or maybe some witty saying. Now I thought I would change it to display the username and display that in the box as well as getting a little message based on the time of the day. The part I haven't tested yet is this;


' Get a Message based on the Time of Day
Dim MyTime As Integer
Dim MyHour As Integer
Dim MyMsg As String
'
MyTime = Time
MyHour = Hour(MyTime)
If MyHour <= 5 Then
MyMsg = "WOW! What are you doing here?"
ElseIf MyHour >= 6 And MyHour <= 7 Then
MyMsg = "You are here early today."
ElseIf MyHour >= 7 And MyHour <= 11
MyMsg = "Good Morning!"
ElseIf MyHour >= 12 And MyHour <= 16 Then
MyMsg = "Good Afternoon."
ElseIf MyHour >= 16 And MyHour <= 18 Then
MyMsg = "Are you staying late?"
ElseIf MyHour >= 19 And MyHour <= 21 Then
MyMsg = "Do you know what time it is?"
ElseIf MyHour >= 22 And MyHour <= 24
MyMsg = "You are a night crawler!"
Else
MyMsg = "You really are staying late!"
End If

As I don't want to set my clock to test each of these times to see if it works, does the logic with the If/ElseIf/Then flow look correct that it should work for those odd hours of before I get into work, and the times I am already home.

The flow looks correct, but I don't remember if I have worked to much with the If/ElseIf in a while.

Thanks for any feedback.

Tim

[pbaldy]

Offhand it looks okay, though I'd probably use Select/Case and dump the variables:

Select Case Hour(Now)

but of course I'm lazy. Also, you don't really need the >= test in tests after the first. Both If/Then and Select/Case will drop out after the first "True" test, so you can simply test for <=5, <=7, etc. In other words, if the hour is 7 you already know it's >= 6 since it got past the first test, so you can simply test for <=7.

[SteveF]

Code looks OK to me as long as you change the formatting to get the ElseIf's and their matching THEN's on one line. You also have a couple of places where you've got a range overlap: "ElseIf MyHour >= 12 And MyHour <= 16 Then..." and "ElseIf MyHour >= 16 And MyHour <= 18 Then..." is one of them; I'll let you find the other.

Personally, for code like this I tend to prefer to use SELECT CASE / END SELECT. To me it's a lot easier to read and follow the flow...

[HMEpartsmanager]

Paul & Steve, thank you for the comments. I grew up with the If/Then crowd and have not used Select Case, but now is a good time to review how that works. Thanks for the tips.

Tim

[pbaldy]

No problem Tim.

[orange]

Just a comment on your statement

As I don't want to set my clock to test each of these times to see if it works, does the logic with the If/ElseIf/Then flow look correct that it should work for those odd hours of before I get into work, and the times I am already home.

.

Instead of working with Time, the system function, for testing/development you just create a variable (eg XXTime) and assign it various values in your code to represent different times. This allows you to check your code, without having to modify your Clock/Time.

Good luck with your project.

[HMEpartsmanager]

Just a comment on your statement
.

Instead of working with Time, the system function, for testing/development you just create a variable (eg XXTime) and assign it various values in your code to represent different times. This allows you to check your code, without having to modify your Clock/Time.

Good luck with your project.

You know, after you wrote this, I smiled. I completely forgot about just assigning the value myself for testing. Big old slap on the forehead!

[orange]

We've all done it. Looked for something more difficult than required.....
Good luck.