On Error GoTo Line0 Not working the way I want it to work?

[ramirezx@ddmfg.com]

Hi,

I hope someone can help, I trying to copy files in two different folders from an Access Form, if the file does not exist to GoTo the next Line, for some reason it running all the queries. What I want it to do is if an error occurs to GoTo Line0 and Resume Next skipping the two queries highlighted in RED?

Is there another On Error I can use that will skip the queries when the file copy error's out. I only want the queries to run if no error occurs?

Thanks,


Xavier

-------------------------------------------------------------

Private Sub Command0_Click()

'Device 0, Weld Station 04---------------------------------------------------------------------------------------------------------------


On Error GoTo Line0
FileCopy "P:\AccessDB\WeldingData\WeldData\Controls\Channel 0\Device0\dc\welddata_" & [txtFileNameDateTest] & ".csv", "P:\AccessDB\Welding Results\welddata.csv"


FileCopy "P:\AccessDB\WeldingData\WeldData\Controls\Channel 0\Device0\dc\welddata_" & [txtFileNameDateTest] & ".csv", "P:\AccessDB\Welding Results\DailyCopies\DEV_00_04_" & [txtFileNameDateTest] & ".csv"


DoCmd.OpenQuery "qry_00c_DEV_00_04_MinWTimeStamp"
DoCmd.OpenQuery "qry_00c_DEV_00_04_MaxWTimeStamp"


Line0:
'This will skip previous lines of code and continue starting on Line0
Resume Next


'Device 1, Weld Station 19---------------------------------------------------------------------------------------------------------------


On Error GoTo Line1
FileCopy "P:\AccessDB\WeldingData\WeldData\Controls\Channel 0\Device1\dc\welddata_" & [txtFileNameDateTest] & ".csv", "P:\AccessDB\Welding Results\welddata.csv"


FileCopy "P:\AccessDB\WeldingData\WeldData\Controls\Channel 0\Device1\dc\welddata_" & [txtFileNameDateTest] & ".csv", "P:\AccessDB\Welding Results\DailyCopies\DEV_01_19_" & [txtFileNameDateTest] & ".csv"


DoCmd.OpenQuery "qry_00c_DEV_01_19_MinWTimeStamp"
DoCmd.OpenQuery "qry_00c_DEV_01_19_MaxWTimeStamp"


Line1:
'This will skip previous lines of code and continue starting on Line1
Resume Next


'Device 2, Weld Station 51---------------------------------------------------------------------------------------------------------------


On Error GoTo Line2
FileCopy "P:\AccessDB\WeldingData\WeldData\Controls\Channel 0\Device2\dc\welddata_" & [txtFileNameDateTest] & ".csv", "P:\AccessDB\Welding Results\welddata.csv"


FileCopy "P:\AccessDB\WeldingData\WeldData\Controls\Channel 0\Device2\dc\welddata_" & [txtFileNameDateTest] & ".csv", "P:\AccessDB\Welding Results\DailyCopies\DEV_02_51_" & [txtFileNameDateTest] & ".csv"


DoCmd.OpenQuery "qry_00c_DEV_02_51_MinWTimeStamp"
DoCmd.OpenQuery "qry_00c_DEV_02_51_MaxWTimeStamp"


Line2:
'This will skip previous lines of code and continue starting on Line2
Resume Next


MsgBox ("Import Completed")

[Micron]

1) get rid of the resume next. That sends it backwards to the line following the line where the error occured
2) please use code tags with proper indenting for more than a few lines of code
3) less important - you could trim out a lot of the repeated verbiage by using variables or sub procedures for repetitive tasks

[Micron]

I didn't really do justice with my answer. In fact, it's considered bad form to use goto's to direct flow beyond the norm. Yours is beyond.
What would be better is to pass the path to a sub procedure, and if that procedure errs, then just exit it. Whether or not you report the error details would be up to you, but I presume you'd still want the other executions of the file copy to occur anyway. Thus you just move on and call the sub again, passing new path parameters.

[ramirezx@ddmfg.com]

Thanks, I will give it a shot, I was looking in my VBA book for tags, which I couldn't really find anything about tags. I will try the pass to a sub procedure and see what happens?

I'm getting better with VBA but I still have a long way to go!

I will let you know what happens!

Thanks again,
Xavier

[Micron]

To apply the tag here, you use the # button on the toolbar. You could try it out by highlighting all the posted code and clicking it. If you wait too long, you won't be able to edit your post. Maybe just for fun we can compare results between your approach and mine (if I have the time)?