For without next, if without end if warnings driving me crazy!

[Gina Maylone]

Hello everyone!



I don't know if I'm brain damaged or what, I'm working on a very simple routine to deactivate the Main Menu buttons if it is past a certain date (for demo purposes). My main menu (mainmenuskeleton) has a current date field (todaysdate) and a "license" field (bound to the underlying table, CompanyInformation) and several command buttons to open various forms. My code:

Private Sub Form_Load()

    Dim ctrl As Control

    For Each ctrl In Me.Controls
        If Forms![mainmenuskeleton]!todaysdate > #4/1/2017# And TypeOf ctrl Is CommandButton Then
            Debug.Print todaysdate

            ctrl.Enabled = True
            Me.license.Visible = True

        End If
    Next
    
    Me.license.Visible = True
        If Me.license = "p060117" Then
        For Each ctrl In Me.Controls
            ctrl.Enabled = True

        End If
    Next


End Sub

I keep getting the error "end if without block if" with the last "end if" highlighted. And if it's not the "IFS" giving me trouble, I will get errors on "For without next". Grrrrrrr. TIA!

[ranman256]

    Me.license.Visible = True
        If Me.license = "p060117" Then
        For Each ctrl In Me.Controls
            ctrl.Enabled = True
        next
        End If
    Next

[Gina Maylone]

Thank you ranman!

So end if doesn't have to come before next? I read a thread that it did! Working now. Thanks again!

[Gina Maylone]

I did speak too soon. I am now getting an error "object doesn't support this property or method" highlights "ctrl.enabled=true". And here's the code again:

Dim ctrl As Control

    For Each ctrl In Me.Controls
        If Forms![mainmenuskeleton]!todaysdate > #4/1/2017# And TypeOf ctrl Is commandbutton Then
            Debug.Print todaysdate

            ctrl.Enabled = False
            Me.license.Visible = True

        End If
    Next
    
       Me.license.Visible = True
        If Me.license = "p060117" Then
        For Each ctrl In Me.Controls
            ctrl.Enabled = True

        Next
        End If

Thoughts?

[Micron]

You indent your code, which is very good practice. That will help you spot such errors - it helps you see incomplete "blocks". Which comes before which really depends on the order that the pairs are nested which is done according to how you want to execute the logic, so assuming my If is to be processed independently from the With

For
 If
  With

must be paired as

For
  If

  End If
  With
  
  End With

Next

If my With is to be dependent on my If then it would be

For
  If
    With
  
    End With

  End If

Next

and I would alter my indentation to reflect that. It's like brackets; they are grouped as pairs.
EDIT:

TypeOf ctrl Is commandbutton Then

I've never seen that syntax or type declaration. Try And ctl.Type = acCommandButton
I think your code could use a bit of tweaking if you want me to make suggestions.

[Gina Maylone]

You indent your code, which is very good practice. That will help you spot such errors - it helps you see incomplete "blocks". Which comes before which really depends on the order that the pairs are nested which is done according to how you want to execute the logic, so assuming my If is to be processed independently from the With

For
 If
  With

must be paired as

For
  If

  End If
  With
  
  End With

Next

If my With is to be dependent on my If then it would be

For
  If
    With
  
    End With

  End If

Next

and I would alter my indentation to reflect that. It's like brackets; they are grouped as pairs.
EDIT:

I've never seen that syntax or type declaration. Try And ctl.Type = acCommandButton
I think your code could use a bit of tweaking if you want me to make suggestions.

Of course, I am always open to suggestions Micron! Thank you for taking the time!

[pbaldy]

I am now getting an error "object doesn't support this property or method" highlights "ctrl.enabled=true".

You're hitting a control that doesn't have the enabled property, like a label. Either test for the types of controls you want to affect, or use the Tag property to identify the controls you want to affect.

[Gina Maylone]

PBaldy - I am testing for commandbuttons (ctl.Type = acCommandButton) per micron. You guys, this is so weird. I used ranman's suggestion and it worked fine, disabled all the command buttons as I wanted. Now when I go into the menu, I get "object doesn't support this property or method". Why would Access decide mid-stream it's not going to support it?! I am able to disable the buttons individually, which is a drag. Still open for suggestions. Thanks everyone for the time!

[pbaldy]

You've got two loops. The first checks the control type; the second does not.

[Micron]

I might not be understanding the logical tests (i.e. what if the date passes but the license does not, or vice versa?) but I'm thinking they can be combined. Plus, it seems license is visible regardless, so it may as well be set once. The first avoids having to evaluate the tests for every command button.

Dim ctrl As Control

Me.license.Visible = True 'seems to be the case regardless, so only written once
If Forms![mainmenuskeleton]!todaysdate > #4/1/2017# Or Me.license <> "p060117" Then
  For Each ctrl In Me.Controls
    If ctrl.Type = acCommandButton Then ctrl.Enabled = False
  Next
Else
  For Each ctrl In Me.Controls
    If ctrl.Type = acCommandButton Then ctrl.Enabled = True
  Next
End If

Another way is less code, but requires the evaluation to take place for each command button. Either way is a bit shorter than what you had; just thought I'd show some alternatives. I have to presume all is nested correctly as I can't test the above. Sure would be embarrassing if it wasn't, given that's the initial subject here.

Dim ctrl As Control

Me.license.Visible = True
For Each ctrl In Me.Controls
  If Forms![mainmenuskeleton]!todaysdate > #4/1/2017# Or Me.license <> "p060117" Then
    If ctrl.Type = acCommandButton Then ctrl.Enabled = False
  Else
    If ctrl.Type = acCommandButton Then ctrl.Enabled = True
  End If
Next