trying to compact code

[trevor40]

I have these lines of code, how can I join them together?


Controls("toggle" & i).Caption = rs![hex code]
Controls("text" & i).Caption = rs![hex code]

I tried
Controls("toggle" & i).Caption = Controls("text" & i).Caption = rs![hex code]

but then Controls("toggle" & i).Caption control comes up with true, the other one still works ok.

[amrut]

The above code is ok for few controls. For more, may be a little odd to rename both type controls using same abbreviation, but is certainly effective.
Rename all such controls like ctlName1,ctlName2,ctlName3.
Then you can easily loop through them -

For i=1 to 3
Me("ctlName" & i).Caption=rs![hex code]
Next i

[trevor40]

heres the code I am using, I'm already doing a loop in there for multiple controls.

Dim db As DAO.Database
Dim rs As DAO.Recordset
Dim strMsg As String
Dim lngMove As Long
Dim col_sel As Long
Dim rr As Long, gg As Long, bb As Long
Set db = CurrentDb
Set rs = db.OpenRecordset("html hex codes", dbOpenDynaset)
SetColors (0)
Me.listcnt = 1
For i = 1 To 36
Controls("toggle" & i).Caption = rs![hex code]
Controls("toggle" & i).ForeColor = Val("&H" & Mid(rs![hex code], 1, 2)) + Val("&H" & Mid(rs![hex code], 3, 2)) * CLng(256) + Val("&H" & Mid(rs![hex code], 5, 2)) * CLng(65536)
Controls("text" & i).Caption = rs![hex code]
Controls("text" & i).BackColor = Val("&H" & Mid(rs![hex code], 1, 2)) + Val("&H" & Mid(rs![hex code], 3, 2)) * CLng(256) + Val("&H" & Mid(rs![hex code], 5, 2)) * CLng(65536)
rs.MoveNext
Next i
rs.Close

[amrut]

I think that is the correct way to do it.

[robrich22]

You could try something like this

Dim ctrl As Control
Dim txt As TextBox

For Each ctrl in Form.Controls
   If TypeOf ctrl Is TextBox Then
      ctrl = txt
      txt.Text = rs.Fields("whatever")
   End If
Next

[trevor40]

I'm trying to put these 2 lines of code together, no real reason just trying to reduce code line count

Controls("toggle" & i).Caption = rs![hex code]
Controls("text" & i).Caption = rs![hex code]

I tried - Controls("text" & i).Caption = Conrols("toggle" & i).Caption = rs![hex code]

First part returns true, the other has correct value

Any other way to do this?

[June7]

This

Controls("toggle" & i).Caption = Controls("text" & i).Caption = rs![hex code]

Is saying "set the caption of control on left side of the first = sign to the value of the expression on the right side of the first equal sign". The expression on right side will evaluate to either True or False.

Can do what you already have working or cycle through all controls as shown by robrich22.

[ipisors]

I agree with Amrut; you're already doing it the correct way ... Why do you feel there is a need to combine those two lines onto one line?
You might be able to get away with an old trick like: one independent statement : the next independent statement, which is how multiple lines of code are [sometimes successfully] run in the Immediate window, but this really doesn't make any sense to try to do as a regular habit (if ever) in a module.

[trevor40]

I have a lot of code like this, update many fields with the same data, (Colors,code,references.) i was only trying to remove some lines of code, not desperate to do it, just curious if it could be done.

[ipisors]

Then you may want to consider maintaining a table that stores information about the form name, control name, type of setting (color, label, rowsource, controlsource), and then write a procedure that sets all of it there.
In this suggestion I'm not necessarily aiming for "less code", but even more importantly: scalability, sustainability.