Problem: can't keep main form and a pop up synchronized

[BrittenTony]

Completely stumped. I've tried several methods. The latest one, which looked very elegant to me, is this http://www.tek-tips.com/faqs.cfm?fid=5860

The code compliles without error. I've inserted the procedure call in the "Master" form, in the OnCurrent event. Nothing happens, not even an error msg. The code is in the Master Form's module. I tried inserting it in a new, public module, but Access gave me errors. I have very little hair left to pull out. I am a VBA novice.

Code in form module:
Option Compare Database
Function IsOpenFrm(frmName As String) As Boolean
Dim cp As CurrentProject, Frms As Object
Set cp = CurrentProject()


Set Frms = cp.AllForms
If Frms.Item(frmName).IsLoaded Then
If Forms(frmName).CurrentView > 0 Then
IsOpenFrm = True
End If
End If
Set Frms = Nothing
Set cp = Nothing
End Function

Function call in OnCurrent property:
If IsOpenFirm("BranchesALLDecisionEditQForm") Then Forms!BranchesALLDecisionEditQForm.Requery End If

The two forms are initially synchronized using this code:
Public Sub ButtonOpenForm_Click()
DoCmd.OpenForm "BranchesALLDecisionEditQForm", , , "[DecisionNo]=[Forms]![JoinAllBranchesForm]![DecisionNo]"

[pbaldy]

Unless it's a typo, I'd expect an error. Here is the function name and how you call it:

IsOpenFrm
IsOpenFirm

[BrittenTony]

Unless it's a typo, I'd expect an error. Here is the function name and how you call it:

IsOpenFrm
IsOpenFirm

Thanks. I accidentally sent an earlier copy of the code. I removed the "i" in response to an error msg saying Access couldn't find a VBA or macro by that name. After fixing the spelling, I didn't get hits from the compiler or any error messages. But the pop up didn't change records when the main form did. Any tips on tracking down errors? I'm going to try, for the first time, to use the VBA editor to single step through my code, though that sure doesn't look like as easy in VBA as it is for a Macro. Maybe I'll go backward and try to write it as a Macro, and if I can get it right, have Access convert it back to Code to see whatever logical or text problem I'm missing. Still, any tips are appreciated. Thanks. Tony

[pbaldy]

If you haven't figured this out, can you post the db here?

[BrittenTony]

If you haven't figured this out, can you post the db here?

I did finally get to something that worked for me (final code below). Some of my problems were rookie mistakes, like not realizing I had to call the function from the OnCurrent event using the "=" sign. In some of my attempts I may also have erred by mixing function routines with sub routines in the same procedure (don't know if that's allowed). After those kinds of errors, my main two problems were:

1. Finding code to check if PopUp (slave form) is open before running the "OnCurrent" event from the Main (master) form. Shortest method that worked: CurrentProject.AllForms.Item("MyFormName").IsLoade d

2. The Requery method changed the PopUp's underlying query to show the same record as the Main form. But the PopUp form itself wouldn't refresh to show the same records as its underlying query! Neither the Refresh nor Repaint methods work. All I could do to refresh it was close and reopen the form using DoCmd statements. It worked, but was sloppy. The Pop Up would disappear then reappear right over the Main form, blocking the view. After a LONG internet search, the solution was simple, but not intuitive: Reset the RecordSource after the Requery. Not change it. Just re-add the existing RecordSource: Forms!PopUp.RecordSource = "PopUpQuery"


Full code (suggestions on tightening up still welcome).
Option Compare Database
Dim cp As CurrentProject
Dim Frms As Object

' See if pop form is open, and if so, call sub to sync it with main form
Public Function IsOpenFrm(frmName As String) As Boolean
Set cp = CurrentProject()
Set Frms = cp.AllForms
If Frms.Item(frmName).IsLoaded Then
IsOpenFrm = True
End If
If IsOpenFrm = True Then
SyncForms
Else
ClearVars
End If
End Function

'Refresh pop up to match main form
'Sub SyncForms()
Forms!BranchesALLDecisionEditQForm.Requery
Forms!BranchesALLDecisionEditQForm.RecordSource = "BranchesALLDecisionEditQ"
ClearVars
End Sub

'Clear variables used in module
Sub ClearVars()
Set Frms = Nothing
Set cp = Nothing
End Sub

[BrittenTony]

Call to procedure from OnCurrent event: =IsOpenFrm("PopUpForm")
Directions I tried from Internet didn't include the "=" sign as part of the function call, and I'm too novice to know I needed it.

[pbaldy]

Glad you got it sorted out. You only need the "=" when you call the function directly from the properties window, which is presumably what you're doing.