Please approve my code

[deepaksharma]

My respectful greetings to all of you. I want to disable all except a few shortcut keys in the form, for this I have seen the codes on Google and they are working properly but I do not have complete knowledge about such codes.
I want to enable alt + F4 in the form, for this I have modified the code. Please tell me whether I have made the correct modification. If the modification is correct then why I have to write 'End Select' three times in it.


Thank you

Public Sub sb_disablekeys(keycode As Integer, Shift As Integer)
    'All keyboard events with CTRL don’t function anymore with the exception of CTRL+C and CTRL+V
 '   ‘All keyboard events with ALT don’t function anymorge
 '   ‘All function keys are disabled
 
    Select Case Shift
        Case acCtrlMask   '  ‘CTRL pressed
            Select Case keycode
                Case 0 To 16, 18 To 66, 68 To 85, 87 To 255

                'All keycodes with the exception of 17 (CTRL), 67 (CTRL+C) and 86 (CTRL+V) are set to 0.
                    keycode = 0
            End Select
        Case acAltMask      'Alt pressed
                    keycode = 0
    End Select

Select Case keycode  'FOR STOP PGUP & PAGE DOWN
    Case 33 To 34
    keycode = 0
    End Select


    Select Case keycode
        Case vbKeyF1 To vbKeyF16        '        ‘Function key pressed
            keycode = 0
    End Select
End Sub


Private Sub Form_KeyDown(keycode As Integer, Shift As Integer)
sb_disablekeys keycode, Shift

End Sub


Private Sub Form_Open(CANCEL As Integer)
Me.KeyPreview = True
End Sub

Revise Code

Public Sub sb_disablekeys(keycode As Integer, Shift As Integer)
    'All keyboard events with CTRL don’t function anymore with the exception of CTRL+C and CTRL+V
 '   ‘All keyboard events with ALT don’t function anymorge
 '   ‘All function keys are disabled
 
    Select Case Shift
        Case acCtrlMask   '  ‘CTRL pressed
            Select Case keycode
                Case 0 To 16, 18 To 66, 68 To 85, 87 To 255

                'All keycodes with the exception of 17 (CTRL), 67 (CTRL+C) and 86 (CTRL+V) are set to 0.
                    keycode = 0
            End Select
            
                     
       Select Case Shift
        Case acAltMask      'Alt pressed
        Select Case keycode
        Case 0 To 17, 19 To 255
        'Case 0 To 8, 10 To 17, 19 To 255
                  keycode = 0
            End Select               '1 time
            End Select               '2 time
            End Select               '3 time


Select Case keycode  'FOR STOP PGUP & PAGE DOWN
    Case 33 To 34
    keycode = 0
    End Select


    Select Case keycode
        'Case vbKeyF1 To vbKeyF16        '        ‘Function key pressed
        Case vbKeyF1, vbKeyF3, vbKeyF5 To vbKeyF16
            keycode = 0
            
    End Select
End Sub

[Micron]

To answer your question, each Select needs an End Select. You are nesting them, so the Ends have to be properly nested as well. If you indented you code properly such things should be obvious to you. I'm assuming what you have works but would rather view it properly indented to be sure but I'll let you do that. BTW, there should be no need to repeat the Shift select block.

[deepaksharma]

To answer your question, each Select needs an End Select. You are nesting them, so the Ends have to be properly nested as well. If you indented you code properly such things should be obvious to you. I'm assuming what you have works but would rather view it properly indented to be sure but I'll let you do that. BTW, there should be no need to repeat the Shift select block.

Hello Micron,
Thank you very much for replying.
As you have told that every select requires an end select, similarly I have checked in this entire code that every select has been given an end select, yet two end selects are coming extra in this code. Please. See in attached pic.
As you mentioned there is no need to repeat shift selection but if I don't repeat it then Alt F4 key does not work please see in attached pic.
Thank you.

[deepaksharma]

I did not know about vba code indent then I googled it then I came to know that to auto indent vba code third party software is required. Am I right? If yes then please tell which software you are use.
Thank you.

[ArviLaanemets]

Your sub must be something like

Public Sub sb_disablekeys(keycode As Integer, Shift As Integer)


    Select Case Shift
        Case asCtrlMask ' as parameter Shift is integer value, why not simply use the integer matching with asCltrlMask here?
            Select Case keycode
                Case 0 To 16, 18 To 66, 68 To 85, 87 To 255
                    keycode = 0
            End Select
        Case asAltMask ' as parameter Shift is integer value, why not simply use the integer matching with asAltMask here?
            Select Case keycode
                Case 0 To 17, 19 To 255
                    keycode = 0
            End Select
        Case Else
            Select Case keycode
                Case 33 To 34
                    keycode = 0
                Case vbFKey1, vbFKey3, vbFKey5 To vbFKey16
                    keycode = 0
            End Select
    End Select
End Sub

[Welshgasman]

I did not know about vba code indent then I googled it then I came to know that to auto indent vba code third party software is required. Am I right? If yes then please tell which software you are use.
Thank you.

You indent with the Tab key, YOURSELF as you type in your code.

You can get software that will indent all the code where you were to lazy to do so yourself, or have to tidy up someone else's code who also could not be bothered.
Smart Indenter is one I use for the latter situation.

[Minty]

MZ tools has an inbuilt indenter, and works with 64 Bit Office, which Smart Indenter doesn't.
Smart indenter is free however, whereas MZ Tools has a cost.

[Welshgasman]

RubberDuck is another, but that does much more. Takes a bit of getting used to.
https://rubberduckvba.com/Features

[deepaksharma]

Thank you very much to all of you, now I understand it well and welshgasman and minty I am studying further on all the programs you suggested.
I request you all, can any of you please help me in solving the note #3 posted by me also?
I will always be grateful to you.
Thank you.

[Minty]

Avril Laanements Has already given you a neater more verbose method?

You original code should look like this;

Public Sub sb_disablekeys(keycode As Integer, Shift As Integer)
    'All keyboard events with CTRL don’t function anymore with the exception of CTRL+C and CTRL+V
    '   ‘All keyboard events with ALT don’t function anymorge
    '   ‘All function keys are disabled
    Select Case Shift
        Case acCtrlMask   '  ‘CTRL pressed
            Select Case keycode
                Case 0 To 16, 18 To 66, 68 To 85, 87 To 255


                    'All keycodes with the exception of 17 (CTRL), 67 (CTRL+C) and 86 (CTRL+V) are set to 0.
                    keycode = 0
            End Select
                               
            Select Case Shift
                Case acAltMask      'Alt pressed
                    Select Case keycode
                        Case 0 To 17, 19 To 255
                            'Case 0 To 8, 10 To 17, 19 To 255
                            keycode = 0
                    End Select               '1 time
            End Select               '2 time
    End Select               '3 time


    Select Case keycode  'FOR STOP PGUP & PAGE DOWN
        Case 33 To 34
            keycode = 0
    End Select


    Select Case keycode
        'Case vbKeyF1 To vbKeyF16        '        ‘Function key pressed
        Case vbKeyF1, vbKeyF3, vbKeyF5 To vbKeyF16
            keycode = 0
            
    End Select


End Sub

Which highlights why you need the correct number of end selects.

[deepaksharma]

Avril Laanements Has already given you a neater more verbose method?

Thanks, can you tell what is making "select case swift" work twice here?

[Minty]

I have no idea.
You can now see why properly indenting your code makes things more obvious?

Put a break point on the first Select case statement and then walk through the code to see what it is actually doing...

[Micron]

Look at the blue highlights in the image you posted. The pairs are first and last, 2nd and 3rd, 4 and 7, 5 and 6. It is as I originally said.

If your original code gets some indentation it would look something like this (see the notes within):

'ORIGNINAL, INDENTED
Select Case Shift
'if next line is true the next Shift Case will not evaluate so ALT key test is ignored
'if the next line is false, the ALT key test will evaluate
    Case acCtrlMask
        Select Case KeyCode
            Case 0 To 16, 18 To 66, 68 To 85, 87 To 255
                'All keycodes with the exception of 17 (CTRL), 67 (CTRL+C) and 86 (CTRL+V) are set to 0.
                KeyCode = 0
        End Select
         
        Select Case Shift
            Case acAltMask      'Alt pressed
                Select Case KeyCode
                    Case 0 To 17, 19 To 255
                        KeyCode = 0
                End Select               '1 time
        End Select               '2 time
End Select

'if either ALT or CTRL test has evaluated, key code become 0 so this next part won't do anything
'next test seems pointless because 33,34 was already evaluated above (18 to 66)
Select Case KeyCode  'FOR STOP PGUP & PAGE DOWN
    Case 33 To 34
        KeyCode = 0
End Select

'if either ALT or CTRL test has evaluated, key code become 0 so this next part won't do anything
'next test seems pointless because these codes should lie between 87 to 255 AFAIK
Select Case KeyCode
    'Case vbKeyF1 To vbKeyF16        '        ‘Function key pressed
    Case vbKeyF1, vbKeyF3, vbKeyF5 To vbKeyF16
        KeyCode = 0
End Select

[deepaksharma]

Look at the blue highlights in the image you posted. The pairs are first and last, 2nd and 3rd, 4 and 7, 5 and 6. It is as I originally said.

thanks micron
Actually I researched this code yesterday so I got some different experience in it please see the link pic.
Thank you.

[ArviLaanemets]

As I did show in my post #5, there is no need for 2nd 'Select Case Shift' cycle

SELECT CASE Shift
CASE Value1OfShift ' i.e. acCtrlMask
     ' Any number of command lines (i.e. a first SELECT CASE keycode cycle is inserted)
CASE Value2OfShift ' i.e. acAltMask
     ' Any number of command lines (i.e. a second SELECT CASE keycode cycle is inserted)
End Select

When 1st CASE evaluates True, all following command lines are run, until the next line starts with 'CASE', or is 'End Select', and then End Select is run ;
When 1st CASE evaluates False, and there is more code rows before 'End Select' starting with 'CASE', the 2nd CASE is evaluated;
Etc. until End Select is reached.
In case in any section of command lines a new SELECT CASE is started, it must be ended with End Select before next CASE condition of main SELECT CASE, or before End Select of main SELECT CASE, when this is the last command lines section.