Login Issue

[Jimruns919]

I created a form to have users log in. I was able to get everything to work except 1 thing.

When a new user is created they are assigned a password of Password. If they use that password it brings them to a form to change the password and this all works.
The problem I have is this, When they change the password, both the new password AND the temporary password will let them in and I cannot figure out why it does this.

 Dim Userlevel As IntegerDim TempPass As String
Dim ID As Integer
Dim UserVarTemp As String
'TempPass is for Temporaty Password given to the new user


Me.PassTB = DLookup("Password", "Users_TBL", "Username='" & Me.Username.Value & "'")


    If IsNull(Me.Username) Then
        MsgBox "Please Enter a Valid Username!", vbInformation, "Username REQUIRED!"
        Me.Username.SetFocus
        
    ElseIf IsNull(Me.Password) Then
        MsgBox "Please Enter a Valid Password!", vbInformation, "Password REQUIRED!"
        Me.Password.SetFocus
        
        Else
            If (IsNull(DLookup("Username", "Users_TBL", "Username='" & Me.Username.Value & "'"))) Or _
            IsNull(DLookup("Password", "Users_TBL", "Password='" & Me.Password.Value & "'")) Then
            MsgBox "Username or Password is Incorrect!", vbCritical, "Login Denied!"
            Me.Username = ""
            Me.Password = ""
            Me.Username.SetFocus
            
            ElseIf StrComp(Me.PassTB, Me.Password, vbBinaryCompare) <> 0 Then
                    MsgBox "Password is Incorrect!", vbInformation, "Authentication Error!"
                    
        Else
            Userlevel = DLookup("[SecurityLevel]", "Users_TBL", "Username='" & Me.Username.Value & "'")
            TempPass = DLookup("[Password]", "Users_TBL", "Username='" & Me.Username.Value & "'")
            ID = DLookup("UserID", "Users_TBL", "Username='" & Me.Username.Value & "'")
            UserVarTemp = Me.Username
                
                If (TempPass = "Password") Then
                DoCmd.OpenForm "ChangePassword_FRM", , , "[userid]=" & ID
                
                Else
                If Userlevel < 15 Then
                DoCmd.OpenForm "HFCAMainmenu_FRM"
                Forms![HFCAMainMenu_FRM]!CurrentUserTB = UserVarTemp
                
                    Else
                    MsgBox "You do not have Access to this area! Please contact the Systems Administrator for assistance.", vbInformation, "Not Authorized"
                    
                               
        
                End If
                End If
            End If
    End If
                 
End Sub

Any assistance would be appreciated

[CJ_London]

Suggest step through the code, your mixture of if’s,else’s and elseif’s is probably not doing what you think it is?

[Minty]

Sub flibble()

    Dim Userlevel As Integer
    Dim TempPass As String
    Dim ID As Integer
    Dim UserVarTemp As String
    'TempPass is for Temporaty Password given to the new user
    Me.PassTB = DLookup("Password", "Users_TBL", "Username='" & Me.UserName.value & "'")
    If IsNull(Me.UserName) Then
        MsgBox "Please Enter a Valid Username!", vbInformation, "Username REQUIRED!"
        Me.UserName.SetFocus
        
    ElseIf IsNull(Me.Password) Then
        MsgBox "Please Enter a Valid Password!", vbInformation, "Password REQUIRED!"
        Me.Password.SetFocus
        
    Else
        If (IsNull(DLookup("Username", "Users_TBL", "Username='" & Me.UserName.value & "'"))) Or _
            IsNull(DLookup("Password", "Users_TBL", "Password='" & Me.Password.value & "'")) Then
            MsgBox "Username or Password is Incorrect!", vbCritical, "Login Denied!"
            Me.UserName = ""
            Me.Password = ""
            Me.UserName.SetFocus
            
        ElseIf StrComp(Me.PassTB, Me.Password, vbBinaryCompare) <> 0 Then
            MsgBox "Password is Incorrect!", vbInformation, "Authentication Error!"
                    
        Else
            Userlevel = DLookup("[SecurityLevel]", "Users_TBL", "Username='" & Me.UserName.value & "'")
            TempPass = DLookup("[Password]", "Users_TBL", "Username='" & Me.UserName.value & "'")
            ID = DLookup("UserID", "Users_TBL", "Username='" & Me.UserName.value & "'")
            UserVarTemp = Me.UserName
                
            If (TempPass = "Password") Then
                DoCmd.OpenForm "ChangePassword_FRM", , , "[userid]=" & ID
            Else
                If Userlevel < 15 Then
                    DoCmd.OpenForm "HFCAMainmenu_FRM"
                    Forms![HFCAMainMenu_FRM]!CurrentUserTB = UserVarTemp
                Else
                    MsgBox "You do not have Access to this area! Please contact the Systems Administrator for assistance.", vbInformation, "Not Authorized"
                End If
            End If
        End If
    End If
                 
End Sub

I've redone your indenting - I think it makes the issue more obvious...

[Jimruns919]

This helped. Thank you! It came down to brackets [] around the word password where it was comparing the temp password and the actual.

[Minty]

You might consider removing some of your else/else if switches:

 If IsNull(Me.UserName) Then
        MsgBox "Please Enter a Valid Username!", vbInformation, "Username REQUIRED!"
        Me.UserName.SetFocus
        
    ElseIf IsNull(Me.Password) Then
        MsgBox "Please Enter a Valid Password!", vbInformation, "Password REQUIRED!"
        Me.Password.SetFocus
       Else ....

Could be replaced with

 If IsNull(Me.UserName) Then
        MsgBox "Please Enter a Valid Username!", vbInformation, "Username REQUIRED!"
        Me.UserName.SetFocus
        Exit Sub
 End If        
 If IsNull(Me.Password) Then
        MsgBox "Please Enter a Valid Password!", vbInformation, "Password REQUIRED!"
        Me.Password.SetFocus
        Exit Sub 
 End If

Which I think is much easier to read and follow.
You then do similar with the rest of the code and remove the nesting to simplify it further.