File dialog Cancel issue

[KWarzala]

Hello,

I have the following code to open a file dialog so a person can select a file:

Dim f As Object
Set f = Application.FileDialog(3)

f.AllowMultiSelect = False

If f.Show = -1 Then
     For i = 1 To f.SelecteItems.Count
            sFile = Filename(f.SelectedItems(i), sPath)
            Me.txtSelectedFile = sPath & s File
     Next
Else
If f.Show = 0 Then
     MsgBox "No file selected"
End If 
End If

The problem i'm having is if i open the file dialog box and select Cancel, it pops the file dialog up again, then this time when i hit Cancel it shows me my MsgBox "No file selected". I know it has something to do with the For/Next statement, but i can't get it to just Cancel and show MsgBox



I appreciate any help!

[June7]

Is Filename() a custom function? Where is sPath declared and set?

I see a typo in f.SelectedItems.Count

[KWarzala]

Yes, Filename() is a custom function

the code works fine i just don't know how to change it to not have it pop up twice

Public Function Filename(ByVal strPath As String, sPath) As String
    sPath = Left(strPath, InStrRev(strPath, "\"))
    Filename = Mid(strPath, InStrRev(strPath, "\") + 1)
End Function

[June7]

Try:

f.AllowMultiSelect = False
If f.Show = 0 Then
     MsgBox "No file selected"
Else
     For i = 1 To f.SelectedItems.Count
            sFile = FileName(f.SelectedItems(i), sPath)
            Me.txtSelectedFile = sPath & s File
     Next
End If

However, if you don't allow multiple selection, then don't use loop.

f.AllowMultiSelect = False
If f.Show = 0 Then
    MsgBox "No file selected"
Else
    sFile = FileName(f.SelectedItems(1), sPath)
    Me.txtSelectedFile = sPath & s File
End If

[KWarzala]

Sorry, didn't see the second part of your post, i will try that code

thanks

[June7]

It does not for me. But your code is not quite same as mine. And I did not test the Filename() function. Let me try now.

[June7]

Where is sPath declared and set? It doesn't seem to be used for anything in the Filename() function.

I still don't get the repeat popup for either code structure.

[KWarzala]

It no longer pops up twice, but it also no longer sets Me.txtSelectedFile - sPath & sFile

[June7]

It should. I am not testing with textbox, just Debug.Print. The filename is printed to immediate window so I know it is captured and setting value in textbox should work in place of the Debug.Print.

Have you step debugged? Refer to link at bottom of my post for debugging guidelines.

[KWarzala]

that was very helpful, thanks for that.

Now i have a new issue... How do i make it so the person can either double click the file OR click the open button? it doesn't seem to want to let me jump back and forth between those options

[KWarzala]

it's just my computer being weird, i have the same procedure on another form and it works with either method on that one. Thank you for all your help!

[June7]

Not an issue for me. Double click file or single click file then click OK.

One oops. In the code without loop, change the i variable to 1. I edited earlier post.