VBA gone wrong with an if

[Ruegen]

I wanted on close button

If Me.frmSubBookingsControl.Form!StatusID = 5 And IsNull(Me.frmSubBookingsControl.Form!CancellationDate) Or IsNull(Me.frmSubBookingsControl.Form!CancellationContact) Or IsNull(Me.frmSubBookingsControl.Form!CancellationReasonID) Then
MsgBox "You require a date in the Cancellation Date field as well as a reason and a the name of the person who asked to cancel the booking."


ElseIf Me.frmSubBookingsControl.Form!StatusID <> 5 And Not IsNull(Me.frmSubBookingsControl.Form!CancellationDate) Then
MsgBox "If this booking is not cancelled - Please clear the Cancellation Date by returning the status to cancelled and then deleting the Cancellation Date before you can close this form"


ElseIf Me.frmSubBookingsControl.Form!StatusID = 5 And Not IsNull(Me.frmSubBookingsControl.Form!CancellationDate) Then
DoCmd.Close




End If

The idea is that if the user switches from cancelled (5) to uncancelled but doesn't clear the date field then it won't let you close the form - however it stops at the second if

please help! (maybe I require more sleep)

[Rod]

Am I permitted to say that's horrible? No offence meant but your code has little or no structure and is a nightmare to comprehend. If you wish to keep your present logic (and I don't recommend you do) then I'm not sure how VBA will interpret the logical concatenation in the first If statement.

If --- And --- Or --- Or ---

You must include parentheses to make your logic clear.

Better though is to structure your logic. There are two If statements beginning If Me.frmSubBookingsControl.Form!StatusID = 5

Why don't you structure your logic as follows:

If Me.frmSubBookingsControl.Form!StatusID = 5 then
If .....

Else

End If
Else

End If

I can't fill in the gaps because I can't interpret your first statement. Get some sleep!

[Ruegen]

lol thanks

Yes I do appreciate the honest answer. I got some sleep and solved it all - All working thanks.