Too few arguments is driving me crazy....

[Spidee]

Hi guys,

I needed to srart tinkerring in Access/VBA/SQL trying to get some things done. I am reasonably sure I am doing things right, but access keeps on telling me, I am not giving it an argument it wants....any help?
Thank you.

 
    Dim newtest As String
    Dim newrs As DAO.Recordset
    Dim newfilter As String
    Dim rs2 As DAO.Recordset
    Dim asd As String
    newtest = "SELECT test.Helper_ID FROM test GROUP BY Test.Helper_ID"
    Set newrs = CurrentDb.OpenRecordset(newtest)
    Do Until newrs.EOF
        Debug.Print newrs![Helper_ID]
        asd = newrs![Helper_ID]
        newfilter = "SELECT Test.* FROM test WHERE helper_ID = asd"
'this is where I fail....
        Set rs2 = CurrentDb.OpenRecordset(newfilter)
        
        newrs.MoveNext
    Loop

[orange]

I think

newfilter = "SELECT Test.* FROM test WHERE helper_ID = asd"

should be

newfilter = "SELECT Test.* FROM test WHERE helper_ID ='" & asd & "'"

It would help readers if you told/described to them WHAT exactly you are trying to do.

You have dimmed asd as string, and usually (not alway) Ids are numeric. Is that what you intended?

[Spidee]

Orange,

works like a charm! Thank you

Apologies for not explaining what I wanted to do. The intention was:
1. Get a listing of all Helper_ID, which are unique
2. Select the first helper_id, filter on it (create a new recordset), go throught all the records and check if a bunch of conditions are met - if yes, do nothing, if no, add a new record in the original data set with values blablabla
3. Move to next value of the helper_Id.

Its just I still am learning the Syntax.
Peter

[orange]

Glad it's working. Carry on...