If ElseIf Not Working

[theperson]

Here is my code:

Private Sub Command38_Click()On Error GoTo Err_Command38_Click


If InStr(1, Me.[Machine#], "-1") > 0 Or InStr(1, Me.[Machine#], "-6") > 0 Or InStr(1, Me.[Machine#], "-7") > 0 Or InStr(1, Me.[Machine#], "-8") > 0 Or InStr(1, Me.[Machine#], "-9") > 0 Or InStr(1, Me.[Machine#], "-13") > 0 Then
    
    Dim stDocName As String


    stDocName = "Process Info Main"
    DoCmd.OpenReport stDocName, acNormal


ElseIf InStr(1, Me.[Machine#], "-2") > 0 Or InStr(1, Me.[Machine#], "-3") > 0 Or InStr(1, Me.[Machine#], "-4") > 0 Or InStr(1, Me.[Machine#], "-5") > 0 Or InStr(1, Me.[Machine#], "-11") > 0 Or InStr(1, Me.[Machine#], "-12") > 0 Or InStr(1, Me.[Machine#], "-14") > 0 Or InStr(1, Me.[Machine#], "-15") > 0 Or InStr(1, Me.[Machine#], "-16") > 0 Or InStr(1, Me.[Machine#], "-17") > 0 Or InStr(1, Me.[Machine#], "-18") > 0 Or InStr(1, Me.[Machine#], "-19") > 0 Then
    
    stDocName = "rptPrintMasterSetUpSheet"
    DoCmd.OpenReport stDocName, acNormal
    
Exit_Command38_Click:
    Exit Sub


Err_Command38_Click:
    MsgBox Err.Description
    Resume Exit_Command38_Click
End If
End Sub

It is used on a print button on a form. It used to work when I didn't have to be so specific with the numbers (-16, -17, etc) but now I had to put in the ElseIf instead of just the Else it used to be and when a user clicks the print button, nothing happens. In the code editor the macro button keeps popping up when I click Run Code. Here is my old working code:

Private Sub Command38_Click()
On Error GoTo Err_Command38_Click


 If InStr(1, Me.[ID#], "55.1") > 0 Or InStr(1, Me.[ID#], "110.1") > 0 Or InStr(1, Me.[ID#], "110.2") > 0 Or InStr(1, Me.[ID#], "110.3") > 0 Or InStr(1, Me.[ID#], "110.4") > 0 Or InStr(1, Me.[ID#], "165.1") > 0 Then
    
    Dim stDocName As String


    stDocName = "Process Info Main"
    DoCmd.OpenReport stDocName, acNormal
    
Else
    
    stDocName = "rptPrintMasterSetUpSheet"
    DoCmd.OpenReport stDocName, acNormal
    
Exit_Command38_Click:
    Exit Sub


Err_Command38_Click:
    MsgBox Err.Description
    Resume Exit_Command38_Click
End If
End Sub

What is my problem?!

[June7]

Move the Dim statement outside the If Then Else.

The Exit_ and Err_ code should be outside the If Then Else.

Can put the DoCmd.OpenReport outside the If Then Else.

I don't think the code for -14, -15, -16, -17, -18, -19 will ever run because the -1 criteria is met first. You need to switch around the criteria.

The macro dialog opens because the procedure is behind a form.

Step debug. Refer to link at bottom of my post for guidance on debug techniques.

[theperson]

New code looks like this:

Private Sub Command38_Click()On Error GoTo Err_Command38_Click
Dim stDocName As String


If InStr(1, Me.[Machine#], "-13") > 0 Or InStr(1, Me.[Machine#], "-6") > 0 Or InStr(1, Me.[Machine#], "-7") > 0 Or InStr(1, Me.[Machine#], "-8") > 0 Or InStr(1, Me.[Machine#], "-9") > 0 Or InStr(1, Me.[Machine#], "test") > 0 Then

    stDocName = "Process Info Main"
    DoCmd.OpenReport stDocName, acNormal

ElseIf InStr(1, Me.[Machine#], "-2") > 0 Or InStr(1, Me.[Machine#], "-3") > 0 Or InStr(1, Me.[Machine#], "-4") > 0 Or InStr(1, Me.[Machine#], "-5") > 0 Or InStr(1, Me.[Machine#], "-11") > 0 Or InStr(1, Me.[Machine#], "-12") > 0 Or InStr(1, Me.[Machine#], "-14") > 0 Or InStr(1, Me.[Machine#], "-15") > 0 Or InStr(1, Me.[Machine#], "-16") > 0 Or InStr(1, Me.[Machine#], "-17") > 0 Or InStr(1, Me.[Machine#], "-18") > 0 Or InStr(1, Me.[Machine#], "-19") > 0 Then
    
    stDocName = "rptPrintMasterSetUpSheet"
    DoCmd.OpenReport stDocName, acNormal
    
End If

Exit_Command38_Click:
    Exit Sub

Err_Command38_Click:
    MsgBox Err.Description
    Resume Exit_Command38_Click

End Sub

It still does nothing when I click the button. If I moved that report command outside the ifthenelse statement, it gave me an error that it needs a report argument.

[June7]

Then it is doing something, just not what you expect. So none of the criteria are being met and need to find out why. Have you step debugged? What is the value of Machine#?

Advise not to use spaces or special characters/punctuation (underscore is exception) in names.

[Missinglinq]

In the code you have to move the On Error statement

On Error GoTo Err_Command38_Click

below the Sub Header; the above, with it on the same line, may be because of your copying and pasting the code here.

The 'nothing happening' could be the result, as June7 said, of the [Machine#], for the Current Record, not having any of the Values (-14, -15, etc.) that you have in the IF...ElseIf construct; you've made no allowance for anything else. Try adding an Else Clause just before the End If, such as

Else
 Msgbox "No Machine Match Found!!!"
End If

and see what happens.

BTW, it is imperative that all Dim Statements appear at the top of a Sub, above everything except the OnError GoTo statement! Don't really know why, but I have seen placement elsewhere in a Sub, such as inside of a If...Else construct, cause the Access Gnomes to have hissy fits!

Linq ;0)>

[theperson]

Adding that no machine found statement in does return that error machine. I'm not sure why though, it must have something to do with me switching to "-#" instead of "55.1" like I was doing before. I type in '10138-2' in the field and it doesn't work. But if I changed it back to '10138-55.1' and changed the code back to trying to find "55.1", that will work just fine. It must be something to do with trying to find "-2".

If I try to search for "10138" specifically in the code, it still returns no machine found.

EDIT: Nevermind, I found the issue. I've been using [Machine#] instead of [ID#] for this certain button. But you guys helped fix another inevitable issue with the "-1". Thanks!