Code Issue

[pbaker]

when trying to load a form there is some code that was programmed by someone else and its coming up with the following error invalid bracketing of name ' passengers'. but for some reason i cannot see the problem.



i think i have found the code its running which is:

sql3 = "SELECT [Title],[Firstname],[Surname],[Address1],[Address2],[Wchair] FROM [" & table & " Passengers] WHERE ([" & table & " Passengers].[Reg])=" & Reg & ";"

can anyone see where the problem is.

[RuralGuy]

Probably! What value is in the "table" variable? What is the actual name of the Table at which you will be looking?

[help_me_with_access]

that's because it IS invalid syntax.


this should take away that specific error:

sql3 = "SELECT [Title],[Firstname],[Surname],[Address1],[Address2],[Wchair] FROM [" & table & "] " & _
"WHERE ([" & table & "].[Reg])=" & Reg & ";"

but the word "Passengers" is in your statement. what is that? gotta figure that out too. if it means nothing, or if it is part of the tablename, it should be included in the "table" variable anyway.


by the way, "table" is a reserved word in the access program so name your variable something else. you're going to corrupt your access files by using "table" as variable names.

[pbaker]

thank you for your help, like i say this database was created by an outside company some time ago, and now its been given to me to try and fix. thank you for your help in repsonce to ruralguys comments the table name was listed as table = passtab.value

im going to also try and your suggestion help me with access and let you know how i get on. This database i think maybe needs re writing from the ground up.

i have also worked out where the passengers bit comes from the table name was set to passtab.value which further up the code its says [passtab] = "abc" so it seems its looking for a table which does exist called abc passengers.

[RuralGuy]

What value is in the passtab variable? What is the actual full name of the table?

[pbaker]

i dont know why its been setup as variable, like i say i wasnt the one that designed it in the first place but the full table is abc passengers

[help_me_with_access]

Allan,

do you want me to layoff? I'm sure you can handle this...you take it. I'll bow out now. good luck!

[RuralGuy]

Right after the sql3 = put a MsgBox sql3 and see what the string contains.

[pbaker]

I haven't done anything but the database seems to be working again now. Most odd thank you for your help and would you say it would be worth a rewrite

[RuralGuy]

I haven't done anything but the database seems to be working again now. Most odd thank you for your help and would you say it would be worth a rewrite

I would not rewrite it unless absolutely necessary. BTW, if you did nothing to resolve the issue then I would expect the issue to reappear on its own.