Running a code in an inherited Database

[jlgray0127]

I have recently inherited a database. It's all written in code.
I keep getting the error, Check the table name's accuracy.
I have posted the code below. The you select the table name, and click the botton, and it is supposed to run this code... The table names are all accurate, so I am not sure what the error is trying to tell me. I am not really good with code yet.
Can you please help point me in the right direction? Thank you!



Private Sub cmdRun_Click()
On Error GoTo Err_cmdRun_Click


Dim strFile As String

strFile = LCase(Trim(cboTable.Value))


Call Master(strFile)
MsgBox ("The macros have been created and exported to the appropriate folder.")

Exit_cmdRun_Click:
Exit Sub
Err_cmdRun_Click:
MsgBox ("Check the table name's accuracy.")
MsgBox Err.Description
Resume Exit_cmdRun_Click

[RuralGuy]

Here's what your code would look like if you used the Code Tags (the # button in Advanced)

Private Sub cmdRun_Click()
   On Error GoTo Err_cmdRun_Click
   Dim strFile As String   strFile = LCase(Trim(cboTable.Value))
   Call Master(strFile)
   MsgBox ("The macros have been created and exported to the appropriate folder.")
Exit_cmdRun_Click:
   Exit Sub
Err_cmdRun_Click:
   MsgBox ("Check the table name's accuracy.")
   MsgBox Err.Description
   MsgBox Err.Number
   Resume Exit_cmdRun_Click
End Sub

Add the RED line to the code and let us know what the number is.

[jlgray0127]

Got the same error (table accuracy)
"Invalid use of null" after that, and then the number

94

[jlgray0127]

I wish I could attach this thing. It's pretty elaborate... at least to me.
It actually is used to upload data to CAPP+, which is used at the company I am currently working at, for maintaining work instructions, and such for our manufacturing process.
It's my understanding, that there is a spread sheet that changes are made in, then this code is ran, and it updates the system in one huge batch, vs running through and updating all the different screens.
I have used neither process, so without knowing code, or what the database is supposed to really do, in it's completeness, it's kinda difficult for a novice! LOL

[orange]

You would have to investigate Master (a called routine) also since that seems to be where most everything must happen.

[jlgray0127]

This is the Module called CAPPLUS MASTER

WHY WOULD SOME OF THE TEXT BE BLACK, AND SOME BE GREEN? IS THIS RELEVANT?

Function Master(ByVal strFile As String)
'Call DELETE_OPNS(strFile)

Call PARTS_MODIFY_RACK_FROM_SPREADSHEET_VER2(strFile)
Call INSERT_PARTS(strFile)
'Call PARTS_MODIFY_RACK_FROM_SPREADSHEET(strFile)
'Call ADD_TOOLS(strFile)
'Call RELATE_TOOLS(strFile)
Call INSERT_LEVELS(strFile)
'Call CHANGE_INSTRUCTIONS(strFile)
'Call PARTS_MODIFY_RACK_DIFF_OPN(strFile)
'Call ADD_TOOLS_VER_2(strFile)
Call ADD_TOOLS_VER_3(strFile)
Call RELATE_TOOLS_VER_2(strFile)
'Call INSERT_LEVELS_VER_2(strFile)
End Function

[orange]

The green text is typically COMMENTS -- non executable code

The ' mark at start of line identifies a comment

It appears that your operational code is a version of the original code with some lines commented out.
; and modules with some revisions. It's pretty poor practice if there is no associated documentation
to help a new person.

[RuralGuy]

Why can't you attach it? Can you zip it up and attach it?

[jlgray0127]

I believe it is now attached.

[RuralGuy]

It really wants to be running on a certain PC. Have you moved it to a different PC? If you click to the left of the margin in the code window you can start a break point. then run the form and it will stop on at the break point. you can then single step with the F8 key and find which line is causing your error.

[jlgray0127]

Yes. It is owned by one of our managers, here. He sent it to me asking me to fix it for him.
I need to have it set up where I can just have the spreadsheet manually imported into the database, so anyone who owns it, can follow a written instruction and use this.

[orange]

Do you have written instructions on how to run it? Did that manager do the design?
What does Fix mean to him?
My first reaction was that it has almost 0 comments and inconsistent Dim statements and very limited error handling.
I don't mean to be real negative, but without some existing instructions, and some discussion/communication with the developer/operator, I I think it's a very uphill task. Especially if you are trying to figure out what it's for and what it does exactly.

I would hope this stuff exists, but if not I think this is how I would start.
- some sort of high level picture showing how the pieces fit together.
-for each of the called routines(purpose, inputs, outputs,process logic, error trapping)
-set up a version control mechanism so 2 or 3 versions aren't in the same procedure and just commented out
-documentation re one version and the next (what caused the change)
-some test data/transactions that could help consistent testing
-back up procedure to protect the "production system"
-detailed instructions on how to set things up, how to run it
- some meaningful current documentation on the system generally and each of the steps and processes involved

There is a free tool MZTools http://www.mztools.com that can help you with some documentation and error handling.
The tool has features to help find caller routines etc. Highly recommended.

I hope this is helpful.

[RuralGuy]

Orange is correct but did we scare you off with the task at hand?