MsgBox in VBA Editor not popping up

[KrisDdb]

I have a form with a combo box and a button, which when clicked, opens a report based on the option selected in the combo box. For this, in the event procedure of the button click, how do I code it so that if no option is selected in the combo box and the button is clicked, it should display a 'message' as a pop up. I know I should use the MsgBox option but I seem to be going wrong with the If loops. I doubt I am positioning the MsgBox command in the wrong place in the code below, as it does not pop up the msg box as I desire. What do I need to do to get over this?

Heres the code:

Private Sub btnMarket_Click()

If Me.Combo0 <> "" And Not IsNull(Me.Combo0) Then
Dim s As String
s = "1=1"

If Me.Combo0 <> "ALL" Then
s = "Market = '" & Combo0 & "'"

End If

DoCmd.OpenReport "repNewIntakeMarket", acViewPreview, , s

Else

MsgBox "Please select an option from the list of markets. Select All to view all markets.", vbOKOnly, "Market Required"

End If



End Sub

Appreciate your time and thoughts.

[June7]

Try:

Private Sub btnMarket_Click()
Dim s As String
If IsNull(Me.Combo0) Then
    MsgBox "Please select an option from the list of markets. Select All to view all markets.", vbOKOnly, "Market Required"
Else
    If Me.Combo0 = "ALL" Then
        s = "1=1"
    Else
        s = "Market = '" & Combo0 & "'"
    End If
    DoCmd.OpenReport "repNewIntakeMarket", acViewPreview, , s
End If
End Sub

[KrisDdb]

Oh! The things I do!! I was equating Me.Combo0 <> "ALL" instead of Me.Combo0 = "ALL". I added a bit more to your code as I had to put in a second combo box based on the value of the first one (newer requirement!). In case someones interested, this is what it looks like now:

Code:

Private Sub btnIntakeMarket_Click()

If Me.Combo0.Value = "Choose Market" Then

MsgBox "Please select an option from the list of markets. Select All to view all markets.", vbOKOnly, "Market Required"

Else
If Me.Combo0 = "ALL" Then
Dim s As String
s = "1=1"

Else

If Me.Combo0 <> "ALL" Then
s = "Market = '" & Combo0 & "'"

If Combo1 <> "ALL" And Combo1 <> "" And Not IsNull(Combo1) Then
s = s & " AND [type] = '" & Combo1 & "'"
End If
End If

End If
DoCmd.OpenReport "repNewIntakeMarket", acViewPreview, , s

End If

End Sub

Appreciate the quick and precise reply. Will mark this as solved.