ByRef argument type mismatch

[uoghk]

I use "ThisRecord" as a parameter to tell a sub "UpdateRecords" how to update a table.


The code likes below. But I get error "ByRef argument type mismatch" on "ThisRecord".

Dim ThisRecord As String


Private Sub Form_Open(Cancel As Integer)
ThisRecord="A"
.....
End Sub


Private Sub Button_Click()
Call UpdateRecords(ThisRecord,...)
End Sub


Private Sub UpdateRecords(TxType As String, ...)
...
End Sub

However, I add a temp variable str in Button_Click as below, then it works.

Private Sub Button_Click()
Dim str as String
str=ThisRecord
Call UpdateRecords(str,...)
End Sub

[Bob Fitz]

Perhaps ThisRecord should be declared with Public rather than Dim

[uoghk]

I also have other variables at the top of the program.
These variables work well in different sub within the program.

[Bob Fitz]

What's the name of the button control? You have: Private Sub Button_Click()

[uoghk]

the button name is btnSave

[Bob Fitz]

the button name is btnSave

So perhaps you need: Private Sub btnSave_Click()

[moke123]

Are you changing the value of "ThisRecord"?
The default is ByVal and you dont show ByRef in your arguement.

Private Sub UpdateRecords(ByRef TxType As String, ...)

[CJ_London]

think that is the other way round

ByRef is the default and references the passed variable and can modify it within the sub or function (can be useful if you want to modify a number of values in one pass)

Sub setStr(str As String)
    str = "abc"
End Sub


Function testsetStr()
Dim s As String
    setStr s
    Debug.Print s
End Function

and in the immediate window

?testsetStr()
abc

ByVal takes the value and although it can be modified within the sub/function, the modified value is not passed back as it is with ByRef

OP has provided air code so my guess is in the real code, ThisRecord gets modified somewhere between the form opening and the button being clicked

Edit:
Interestingly the OP uses Call, which I haven't used for over 20 years (it's a throwback to the early days of VB and only kept in for backwards compatibility), so thought I'd check out the variations

So
setStr s produces the result as above
Call setstr(s) produces the same result

but

Call setStr s does not - it would appear that by leaving out the brackets ByRef's are treated as ByVals so s remains as its original value when passed as a parameter.

Pretty sure somewhere this will be documented, but I don't have time to go looking

[moke123]

think that is the other way round

I stand corrected. I went to check before I posted and I saw ByVal as the default but I think it may have been in .Net

[CJ_London]

I think it may have been in .Net

it is

[uoghk]

Thanks Ajax.
I ONLY set a value to ThisRecord on Form_Open.

I add ByVal in sub then it works.

Private Sub UpdateRecords(ByVal TxType As String, ...)
...
End Sub

I am a newbie. I use Access for just 1 month.
I will remove using the CALL.

Thanks all of you.