Save Report as PDF - Filter not working

[TOPSie]

This is driving me mad. In some inherited code are lots of examples of saving reports as PDF files, prior to emailing them.
So I have copied working code and changed it for an existing report:

If gMessage = "Option1" Then    DoCmd.OpenReport "repPaymentHistory", acViewPreview, , "customerid=" & intCustomerID & "", acDialog
Else


    gEmailMessage = "Please see attached Payment History Report"
    strFolder = Left(CurrentDb.Name, Len(CurrentDb.Name) - Len(Dir(CurrentDb.Name)))
    strFile = "PaymentHistory.pdf"
    strPath = strFolder & strFile
    DoCmd.OpenReport "repPaymentHistory", acPreview, , , acHidden
     
    Reports![repPaymentHistory].Filter = "CustomerId=" & intCustomerID
    
    DoCmd.Close acReport, "repPaymentHistory", acSaveYes
    DoCmd.OutputTo acOutputReport, "repPaymentHistory", acFormatPDF, strPath, False

"Option1" simple displays the report on the screen giving just one page for the relevant CustomerId.



However the else branch produces a PDF file with several thousand pages - there are lots of customers!!!

The Report design has FilterOnLoad = True.
The only clue I have is that CustomerId is not used in the Report, but in a Query which is the DataSource of the Report (but it works for the "option1" branch????

[Welshgasman]

I would just use the filter on the report open as you did with option 1?

[TOPSie]

Thank you.
I removed the Reports! and DoCmd.Close line and changed the Open Report line to acHidden and it all now works.

Does this leave the report hanging around in store? is it best to move the DoCmd Close to the end of the code?

[Welshgasman]

Yes close the report after the output.