Private Sub Assistance

[d9pierce1]

HI all,
Trying to use more Private Subs and call to them to clean up a lot of useless code.
Below is a Private Sub and I want to know is there a better way to write it and what would that be?
I have a status lable on my header of form, It should be standard company unless one of the two
check boxes are clicked. If Preferred is checked, then do not use is not enabled, and vise versa and it


will change the lable to which ever is checked. This all works but something is telling me that the code in
the sub could be condensed into a shorter version but not sure how.
Thanks
Dave

Private Sub CompanyStatus()


    If ChkPreferred = True Then
        Status.Caption = "Preferred Company"
        ChkNoSolicit.Enabled = False
        ChkPreferred.Enabled = True
    Else
        Status.Caption = "Standard Company"
        ChkNoSolicit.Enabled = True
        ChkPreferred.Enabled = True
        
    If ChkNoSolicit = True Then
        Status.Caption = "Do Not Use"
        ChkPreferred.Enabled = False
        ChkNoSolicit.Enabled = True
    Else
        Status.Caption = "Standard Company"
        ChkPreferred.Enabled = True
        ChkNoSolicit.Enabled = True
    End If
    End If
End Sub

[Gicu]

Not sure about your exact requirements\setup but you could replace the two fields Yes\No fields ([Preferred],[NoSolicit]) with one called [CompanyStatus]. Then bind that field to an Option group with three options labeled "Preferred","Do Not Use" and "Standard Company". In the option group wizard set the desired values for those labels (numeric probably best, but you could use the labels themselves). This way you do not need this code at all.

Cheers,
Vlad

[d9pierce1]

Thank you Gicu,
I am trying my best to stay away from option groups as i have found they are hard to get a txt value from at times. In this case, it should be fine as will not be calling the txt value anywhere else so most likely would be an acceptable choice.
I have been playing around with this and came up with this which removed a couple of lines.
Thanks

Private Sub CompanyStatus()


    If ChkPreferred = True Then
        Status.Caption = "Preferred Company"
        ChkNoSolicit.Enabled = False
        ChkPreferred.Enabled = True
    ElseIf ChkNoSolicit = True Then
        Status.Caption = "Do Not Use"
        ChkPreferred.Enabled = False
        ChkNoSolicit.Enabled = True
    Else
        Status.Caption = "Standard Company"
        ChkPreferred.Enabled = True
        ChkNoSolicit.Enabled = True
    End If
    
End Sub

[accesstos]

I agree with Vlad. Option group will be clearer for the user and absolve you from any code and risky disables.
You can use its numeric value in a CHOOSE() function to produce any text result or you can get the caption directly from its labels.
For example, in a textbox:

=[Form].[controls]("Label" & [Frame1]).[Caption]

"Label1" could be the label of the first option etc.

[d9pierce1]

I will do some testing on it.
Thanks
dave

[ssanfu]

Just curious. With two check boxes, there are 4 possibilities.

Private Sub CompanyStatus()

    'Default
    If (ChkPreferred = False And ChkNoSolicit = False) Then
        Me.Status.Caption = "Standard Company"
        Me.ChkPreferred.Enabled = True
        Me.ChkNoSolicit.Enabled = True
    End If

    If (ChkPreferred = False And ChkNoSolicit = True) Then
        Me.Status.Caption = "Do Not Use"
        Me.ChkPreferred.Enabled = False
        Me.ChkNoSolicit.Enabled = True
    End If

    If (ChkPreferred = True And ChkNoSolicit = False) Then
        Me.Status.Caption = "Preferred Company"
        Me.ChkNoSolicit.Enabled = False
        Me.ChkPreferred.Enabled = True
    End If

    If (ChkPreferred = True And ChkNoSolicit = True) Then
    
        Me.Status.Caption = "Oh my. What to do?????"
    
    End If
End Sub

[d9pierce1]

Hi ssanfu,
The way i set it up there is no way to check both boxes as if one is checked, the other is not enabled to check. you must uncheck one to get to the other...
Thanks