Error while trying to use a combobox as a filter

[heinensk23]

I am getting an error with the below code.
Error is attached.


Private Sub cmbo_Menu_Group_AfterUpdate()


Dim myMenugroup As String
myMenugroup = "Select * from tbl_BRASS_Menu_Item_Setup where [MENU_GROUP_TARGET] = & Me.cmbo_Menu_Group "


Me.subfrm_BRASS_ITEM_SETUP_subform.Form.RecordSour ce = myMenugroup
Me.subfrm_BRASS_ITEM_SETUP_subform.Form.Requery


End Sub

[davegri]

if menu_group is a string use this:
myMenugroup = "Select * from tbl_BRASS_Menu_Item_Setup where [MENU_GROUP_TARGET] = '" & Me.cmbo_Menu_Group & "'"


If Menu_Group is numeric then use this:
myMenugroup = "Select * from tbl_BRASS_Menu_Item_Setup where [MENU_GROUP_TARGET] =" & Me.cmbo_Menu_Group

[heinensk23]

MENU_GROUP_TARGET in tbl_BRASS_Menu_Item_Setup is a short text so I used the first option and am now getting another error.

[davegri]

MENU_GROUP_TARGET in tbl_BRASS_Menu_Item_Setup is a short text so I used the first option and am now getting another error.

Maybe be best if you can post the db here for analysis.

[heinensk23]

Unfortunately it's too big to attach. I tried pulling out just the parts I am having problems with and it is still too large.

[Micron]

you have
& Me.cmbo_Menu_Group & " '' " (an extra single quote or a double between doubles; can't tell which).

use
& Me.cmbo_Menu_Group & " ' " (remove spaces I added for clarity).


You probably didn't compact and then zip a cop of your db, which is why it's too large?

[heinensk23]

I don't have an option to zip the database.

[davegri]

I don't have an option to zip the database.

It's built into File Explorer:

[Micron]

has been built into windows versions for quite some time.
https://www.wikihow.com/Zip-a-File-in-Windows-XP

[heinensk23]

Thanks
I have attached

[davegri]

Table is misnamed. Delete the red.

Option Compare Database
Option Explicit


Private Sub cmbo_Menu_Group_AfterUpdate()


Dim myMenugroup As String
myMenugroup = "Select * from tbl_BRASS_Menu_Item_Setup where [MENU_GROUP_TARGET] = '" & Me.cmbo_Menu_Group & "'"
Me.subfrm_BRASS_ITEM_SETUP.Form.RecordSource = myMenugroup
Me.subfrm_BRASS_ITEM_SETUP.Form.Requery


End Sub

Edit: You also don't need the requery. The form had but little choice to requery itself when its recordsource was changed.

[heinensk23]

Thank you!
It's working now.

[davegri]

Glad to help. It's easy to misname things when the names are long and involved. Good luck with the project!