Gett Error 2220 when try to add an image

[Dave14867]

Hello all,

I am trying to load an image file and I get an Error 2220. The code is as follows. I know it is the line "Me.LogoImage.Picture = Me.OrgLogoPath" that is causing the error but I don't understand what is going wrong. when I debug the line OrgLogoPath = the path to the file but Me.LogoImage.Picture = "None".


Private Sub cmdAddLogo_Click()


On Error GoTo SubError
'Add "Microsoft Office 14.0 Object Library" in references


Dim fDialog As Office.FileDialog
Dim varFile As Variant

OrgLogoPath = ""

' Set up the File Dialog
Set fDialog = Application.FileDialog(msoFileDialogFilePicker)

With fDialog
.Title = "Choose the Image you would like to Use"
.AllowMultiSelect = False
' .InitialFileName = "C:\Users\ray\Desktop\Export to Excel" 'Folder picker needs trailing slash

.Filters.Clear
' .Filters.Add "Excel files", "*.xls*"
' .Filters.Add "Excel files", "*.xls"
' .Filters.Add "Excel files", "*.xlsx"
' .Filters.Add "Excel macro-enabled", "*.xlsm"

If .Show = True Then
If .SelectedItems.Count = 0 Then
'User clicked open but didn't select a file
GoTo SubExit
End If

'An option for MultiSelect = False
'varFile = .SelectedItems(1)
'txtSelectedName = varFile

'Needed when MultiSelect = True
For Each varFile In .SelectedItems
OrgLogoPath = OrgLogoPath & varFile & vbCrLf
Me.LogoImage.Picture = Me.OrgLogoPath

Next
Else
'user cancelled dialog without choosing!
'Do you need to react?
End If

End With

SubExit:
On Error Resume Next
Set fDialog = Nothing
Exit Sub

SubError:
MsgBox "Error Number: " & Err.Number & " = " & Err.Description, vbCritical + vbOKOnly, _
"An error occurred"
GoTo SubExit


End Sub

[Micron]

What I wonder about is
a) your comments state that a trailing slash is required but you don't seem to be adding it anywhere
b) why you would put a line feed and carriage return in the file path
c) why have a loop for the dialog when you set multi select to no. Simply test if .Show value is 0 or -1 (not picked or picked)
Your path string might contain invalid characters because of c) or be missing the slash and you haven't noticed.

Please post your code within code tags to format for easier reading.

[moke123]

In addition to Microns observations it appears you do not have option explicit declared in the declarations as I dont see where you dimension OrgLogoPath.

Save yourself some time \ troubles in the future and create a public filedialog procedure in a standard module.
That way you can simplify the code in your form module

Private Sub cmdAddLogo_Click()

     Me.LogoImage.Picture = TheNameOfYourPublicFunction

End Sub

It is also very helpful to add a Debug.Print for the result of your Filedialog function so you can see if it is properly formatted.

Edit: heres a very basic filedialog file picker procedure

Public Function GetFilePath() As String


    Dim strFilePath As String


   On Error GoTo GetFilePath_Error


    With Application.FileDialog(msoFileDialogFilePicker)


        If .Show <> 0 Then
            strFilePath = .SelectedItems(1)
        End If
        
    End With
    
    Debug.Print strFilePath    ' remove in production
    
    GetFilePath = strFilePath


   On Error GoTo 0
   Exit Function


GetFilePath_Error:


    MsgBox "Error " & Err.Number & " (" & Err.Description & ") in procedure GetFilePath of Module Module1"


End Function

[Dave14867]

moke123,

I was going to put it into a module once i got it working the way I wanted to so I could reuse it because I want to down the road a bit. I took your code and used it but when I try to put the result into the txtOrgLogoPath Field it doesn't persist. Also I want to be able to have different images for different records so I want the value of LogoImage.Picture to be the path in txtOrgLogoPath, does that makes sense?

I have attached zip file with a copy of the database. I am just having a mental block on this for some reason.

DaveImageIssue.zip

Thanks for the assistance

Dave

[Dave14867]

I believe I have got it resolved. Now I can have a different picture for each different record. Thanks for the assistance.