The problem you are having is when a sub calls DoCmd.OpenForm is that it will immediately return to executing it's code after it tells the other form to load unless you use the acDialog option for the window mode parameter:
https://docs.microsoft.com/en-us/off...docmd.openform
What's happening is it's loading your dialog form and then immediately executing the rest of the code before the user has a chance to select ok or cancel.
See attached. I've implemented the acDialog option and changed the approach from hiding the window when the user clicks OK to saving a variable in TempVars that the calling sub can then check for results.
https://www.microsoft.com/en-us/micr...2007-and-2010/
I also removed the input mask from the beg and end date text boxes and added a formatting string instead, the input mask wasn't allowing me to enter any changes.
FYI, The linked table manager couldn't find one of your tables in the back end.
Finally, there is a problem in your events_load sub in the scateam accounting module that wouldn't compile, but I didn't have time to debug it.
[EDIT]
There are about half a dozen bugs that won't allow it to compile. Looks like mostly references to changed object names. I'd suggest adding 'Option Explicit' to the top of every code file to help catch these errors as you go
https://www.excel-easy.com/vba/examp...-explicit.html