Syntaks error 3134 ????

[ksor]

Where is this "Syntaks error in 'Insert into' in this:

DoCmd.RunSQL "INSERT INTO PERSON (Fornavn, Mellemnavne, Efternavn, [Efternavn født], Køn, Fødselsdato, Fødested, Dødsdato, Dødssted, Arbejdsnotat) VALUES (" _
                                    & Me.PFornavn.Value & ", " _
                                    & Me.PMellemnavne.Value & ", " _
                                    & Me.PEfternavn.Value & ", " _
                                    & Me.PEfternavn_født.Value & ", " _
                                    & "?" & ", " _
                                    & Me.Fdato.Value & ", " _
                                    & Null & ", " _
                                    & Me.Ddato.Value & ", " _
                                    & Null & ", " _
                                    & "" & ");"

I'm blind ... I can't see it !

[ranman256]

Do not use 'null'.
just don't use the field in the query,it will naturally be null.

[pbaldy]

There's also the question mark. What's that supposed to do? Use a variable and this:

http://www.baldyweb.com/ImmediateWindow.htm

[June7]

I advise not to allow empty string in text fields.

Agree with ranman, if you don't want to populate a field then don't include it in the action.

You want a question mark character in field?

[ksor]

(Why don't I get any message that you answered this thread ?)

The '?' is data for the gender in my DB - so it should be there !

OK, just leave empty fields out - like this:

DoCmd.RunSQL "INSERT INTO PERSON (Fornavn, Mellemnavne, Efternavn, [Efternavn født], Køn, Fødselsdato, , Dødsdato, , ) VALUES (" _
                                    & Me.PFornavn.Value & ", " _
                                    & Me.PMellemnavne.Value & ", " _
                                    & Me.PEfternavn.Value & ", " _
                                    & Me.PEfternavn_født.Value & ", " _
                                    & "?" & ", " _
                                    & Me.Fdato.Value & ", " _
                                    & Me.Ddato.Value & ", " _
                                    & ");"

I leave empty between commas in the FIELD-list ... how should it else match FIELDS to DATA ?

Thx for the answers !

[isladogs]

Remove the empty spaces and superfluous commas in the first line.
I still don't understand the use of a ? in the sql. If you must insert a ? surround it with single quotes '?'
Why aren't you using the gender textbox value instead?

Also, all the .Value can be removed as that is the default property.

When you have issues with sql statements, the fastest solution is to use a debug.print line then paste the output into a query.
It will highlight the first error it finds. Fix that and any subsequent errors found until it works

[ksor]

Thx, again ... I just tried it and I got it to work !

OK, I'll try removeing the .Value too !

I changed the 'gender' to a combobox with 'M', 'F' and '?'

I have to have the '?' in some cases I don't know the gender - yet.

Thx again !

[isladogs]

Or you could use Nz(Me.cboGender,"") in your Sql and remove the '?' from the combo

[June7]

I advise not to save empty string in tables. I would use Nz(Me.cboGender, "N"). N=Not Given.