Need Vb Code Help Output To PDF

[aamer]

Where am I making a mistake in this code, I could not figure out. Need Help




DoCmd.OutputTo ObjectType:=acOutputReport, ObjectName:="General Sales", OutputFormat:=acFormatPDF, Outputfile:="C:\Users\ABC\Desktop (" + CurrentDay + "-" + CurrentMonth + "-" + CurrentYear + ").PDF", False, "", 0, acExportQualityPrint

[ranman256]

vFile ="C:\Users\ABC\Desktop" & "(" & format(date(),"dd-mm-yyyy") & ").PDF"
vRpt = "General Sales"
DoCmd.OutputTo acOutputReport, vRpt, acFormatPDF, vFile

[pbaldy]

You're also going to need a backslash after "desktop". I'd use a variable for the path so you can see how it's ending up:

http://www.baldyweb.com/ImmediateWindow.htm

[June7]

Forum post may have dropped last backslash. Posting between CODE tags should prevent that.

[aamer]

its not working

the complete code is as follows

Private Sub Command19_Click()
On Error GoTo Err_Handler

Const ReportName = "General Sales"
Const MESSAGETEXT = "No customer selected."
Dim strCriteria As String


strCriteria = "CoId = " & Me.cboCustomers


If Not IsNull(Me.cboCustomers) Then

DoCmd.OpenReport ReportName, _
View:=acViewPreview, _
WhereCondition:=strCriteria


vFile = "C:\Users\ABC\Desktop\PDF Reports" & "(" & Format(Date, "dd-mm-yyyy") & ").PDF"
vRpt = "General Sales"
DoCmd.OutputTo acOutputReport, vRpt, acFormatPDF, vFile


Else
MsgBox MESSAGETEXT, vbExclamation, "Invalid operation"
End If

Exit_Here:
Exit Sub

Err_Handler:
MsgBox Err.Description, vbExclamation, "Error"
Resume Exit_Here

End Sub

[pbaldy]

What does "not working" mean exactly? Does the report open? What is the final value in vFile?

[June7]

Please post code between CODE tags so we can be sure missing backslash is due to forum dropping and not really missing in code. Also, to retain indentation and readability.

[aamer]

am getting the compile error variable not defined

[June7]

On which line?

Error handlers interfere with debugging. Disable the On Error GoTo line and then run procedure.

Why would you have a CONST for report name as well as a variable?

Do you have Option Explicit in the module header?

Variables vFile and vRpt are not declared.

Should set variable strCriteria after verifying combobox is not null because strCriteria cannot hold Null and would error if it tried.

[aamer]

i used the following code and it works

Private Sub Command17_Click()
On Error GoTo Err_Handler

Const ReportName = "General Sales"
Const MESSAGETEXT = "No customer(s) selected"

Dim varItem As Variant
Dim strCustomerIDList As String
Dim strCriteria As String
Dim ctrl As Control

Set ctrl = Me.lstCustomers

If ctrl.ItemsSelected.Count > 0 Then
For Each varItem In ctrl.ItemsSelected
strCustomerIDList = strCustomerIDList & "," & ctrl.ItemData(varItem)
Next varItem

' remove leading comma
strCustomerIDList = Mid(strCustomerIDList, 2)

strCriteria = "CoId In(" & strCustomerIDList & ")"

DoCmd.OpenReport ReportName, _
View:=acViewPreview, _
WhereCondition:=strCriteria






DoCmd.OutputTo ObjectType:=acOutputReport, ObjectName:="General Sales", OutputFormat:=acFormatPDF, Outputfile:="C:\Users\ABC\Desktop\PDF Reports\AC-Title Sale" & " " & Format(Date, "dd-mmm-yyyy") & ".PDF"


Else
MsgBox MESSAGETEXT, vbExclamation, "Invalid operation"
End If


Exit_Here:
Exit Sub

Err_Handler:
MsgBox Err.Description, vbExclamation, "Error"
Resume Exit_Here


End Sub

[pbaldy]

Glad you got it working.

[aamer]

I am not sure if my method is correct or not?

[pbaldy]

I thought you said it worked? The only thing I see offhand is that I'd probably close the report after the export, but maybe you want it left open.

[aamer]

Yes indeed it works, maybe i was not able to explain properly.
what I was trying to say was can you check the code that it is correct. Your reply confirms that it is correct. Yes I wanted the report to stay open and be closed manually.

thanks once again for your kind help

[pbaldy]

No problem.