Can't call a Sub in a Module from inside a Class Object

[mcomp72]

I'm pretty new to Access (but been doing VBA in Excel for a little while now), and I have hit a snag. I may be trying to get Access VBA to do something it can't do, but not sure.



I have a form with a button on it. If the user presses the button, I want it to execute a sub in a module. My sub for when the user clicks on the button (the event) is located in the Class Object for that specific form. Here's the code from that sub inside "Form_MyForm" which is in 'Microsoft Access Class Objects'.

Private Sub Command20_Click()

... (some other code that doesn't refer to the Sub I want to call.)

Application.Run Module1.CreatePDFFiles

End Sub


The CreatePDFFiles sub is inside Module1.

When I click on the button and execute Sub Command20_Click, I get a compile error: Expected Function or variable. The part of the line below that is in bold is highlighted blue in my code window:
Application.Run Module1.CreatePDFFiles

I'm not sure what I'm doing wrong. Any ideas?

[pbaldy]

The syntax is normally just the function name:

CreatePDFFiles

[mcomp72]

The syntax is normally just the function name:

CreatePDFFiles

When I remove the rest of the line, I get Compile Error: Syntax Error. In fact, when I deleted rest of the line, the line turned red before I even ran the sub again.

[davegri]

Is the sub set up as Private? Is so, remove the word "Private".

[pbaldy]

Sounds like it's in a standard module. Does it take arguments? Can you attach the db here?

[mcomp72]

davegri: the Sub ‘Command20_Click’ is set to Private; the one that I am trying to run from within ‘Command20_Click’ not. I tried removing the word Private from the one, but the error was still there.

pbaldy: yes, the command takes arguments, but I tried putting a ‘ before the arguments to disable them for testing purposes, but still got the same error.

Here is a link to download the db:
https://www.dropbox.com/s/t5g5oho6l7...ing.accdb?dl=0

Once you have the db open, open the Form "Employees on jobs". There should be one record there. Click the button in the header "Create PDF Files of Start Paperwork." That should open a new form in a new window. All of the check boxes should be checked, but if not, just check one of them. Then click "Create PDF Files". That should attempt to trigger the sub I want to run. The only thing in that sub currently is a MsgBox command -- this is just to test to make sure it's working. I'll write the actual code later.

Thanks for taking a look!

[pbaldy]

Try:

CreatePDFFiles PrintDealMemoTopPage, PrintDealMemoScheduleA, PrintStartForm, PrintBoxRentalForm, PrintI9Front, PrintI9Back, PrintNoticePage1, PrintNoticePage2

[mcomp72]

That worked!

I'm curious, why do we not use the parentheses to pass the arguments to the sub like we normally would? In the past whenever I have used VBA in Excel and needed to pass arguments, I always used parentheses after the sub name.

[Micron]

IIRC, the parentheses are only required where a function or sub call uses the Call keyword, or if it is a function and it is returning a value to a variable. The message box function is a good example:
Result = MsgBox ("message", options) required to pass the value of a choice to Result
MsgBox "message" - not required and will? generate an error if used

[pbaldy]

This should help:

https://msdn.microsoft.com/en-us/vba...ion-procedures

In general, if you use Call or want to use a return value, you have to use parentheses, otherwise not.