Converting Macros to VBA code

[ssanfu]

I am very concerned about the last issue. I must say in my defense that I inherited this db and all the macro that came with it including mcrRestore. I am creating this in a non-profit seeking organization. It will never be sold.

In order to get right with the copyrighted code what must I do? Is it a question of simple copyright and all I need to do is replace the removed copyright?

I can do that. I just do not want to be in copyright violation.

Yes, it is that simple. Go to the access.mvps.org site, copy and paste the lines at the top of the function into the function in your code......



Please note that the comment was in no way directed at you.
You have stated several times before that you had inherited the dB; I was just letting you know what I found.

[ssanfu]

I know that I have mentioned this before, but you have code that has "Form_" as a prefix. That is the way Access uses to know what the object is - you should never use that nomenclature.

Private Sub Form_Close()  '<<-- Good - Required by Access
    Form_frmProjectManagement.Requery   '<<---BAD. You should never reference a form this way!!
End Sub

You have approximately 31 references in the code like this. These need to be fixed!!!

You have the button code in the form "sfrmTelework1" that is trying to requery two sub forms by using this code

Private Sub btnClose_Click()
    Dim response

    If (DCount("*", "tblTelework", "[PersonnelID] = [Forms]![frmPersonnel].[PersonnelID] AND [isActive] = true")) > 0 Then

        response = MsgBox("Are you sure close Telework Contract?", vbYesNo, "Close ", 0, 0)

        If response = 6 Then
            Me.EndDate = Date
            Me.isActive = No
            Form_sfrmTelework1.Requery
            Form_sfrmTelework.Requery
            updateButtons
        End If
    End If
End Sub

I'm not saying this is the cause of the current error, but it will go a long way to fixing a lot of errors...

[Lou_Reed]

These are translated macros to BA code. I did not put the form_ in there. Bill Gates did. I just took the translated code as gospel and there you are.

I can change Form_. I just am not sure why the Macro to VBA translator used it when I and anyone else knows that is wrong.

Any help appreciated. Thanks in advance.

Respectfully,

Lou Reed

[pbaldy]

Many of the wizards create antiquated code; this is an example of that. Frankly, many of the MS sample databases use poor design practices, like spaces in names. Use both as bumps in the right direction, not as-is solutions.

[Lou_Reed]

In the last week I converted the macros to VBA code. So these 31 instances must be in that code. I removed all other instances of Form_ last month before i
translated the macros to VBA code.

Still 31 instances sounds like a lot when you consider the small amount of code.
Anyway thanks for the heads up.

I will check it.

Respectfully,

Lou Reed

[Lou_Reed]

The attached zip fie contains the db that is the one I am working on. There is an inconsistency. I find no other instances of Form_ being used. You said there were 29 others. I do not find them. There are other instances of Form_, but these should not be converted

Any help appreciated. Thanks in advance.

Respectfully,

Lou Reed

[Lou_Reed]

I have made a serious error. In the previous post, I uploaded the wrong file. The one in this post is the correct one.

Please use this one.

Respectfully,

Lou Reed

[Lou_Reed]

After the change of Form_ to Forms! All that happens is that it crashes on the next line.

updateButtons.

That term is used in many places about 7 in all with no complaints from the compiler.

What am I doing wrong?

Any help appreciated. Thanks in advance.

Respectfully,

Lou Reed

[ssanfu]

I thought you had resolved the "Forms_" issue a while ago.....

After the change of Form_ to Forms! All that happens is that it crashes on the next line.

updateButtons.

In an earlier version of the dB, the form "sfrmTelework1" had a sub, "Public Sub updateButtons()", that is now missing from the form module.

Try adding this code back to the form "sfrmTelework1" code module:

Public Sub updateButtons()
    If DCount("*", "tblTelework", "[PersonnelID] = [Forms]![frmPersonnel].[PersonnelID] AND [isActive] = true") = 0 Then
        Me.btnClose.Enabled = False
        Me.btnEditTelework.Enabled = False
        Me.btnNew.Enabled = True
    Else
        Me.btnClose.Enabled = True
        Me.btnEditTelework.Enabled = True
        Me.btnNew.Enabled = False
    End If
End Sub

[Lou_Reed]

I will add the VBA code and thanks for your help.

Respectfully,

Lou Reed

[Lou_Reed]

Yes, that works. Sorry for my stupidity. The updateButtons SUb was clearly shown in the sfrm.PropertyPass1.Requery

The update button Sub was clearly there. All I had to do was to copy it and paste in the code where it was needed: .
the Sub for sfrmTelework etc.

My questions since it got there in one sub code and not another is this not an error in the macro to VBA code translator?

I could have clumsily eliminated it in the SUB where it was missing, but I do not think that I did.

I assume that it is put there by the macro to VBA translator that is in MS Access 2010.

So why did it go in one sub and not another.

Strange.

Also, when I went to compile the compile line was at times greyed out and I could not compile. How can I ungrey it out and use it. It is of no use to me
in the greyed form?

Any help appreciated. Thanks in advance.


Respectfully,


Lou Reed

[pbaldy]

If the compile option is greyed out, the project must already be compiled. Make and save any code change to enable it.

[Lou_Reed]

Ah, OK. I think I see what you want to do know. You want to run the VBA code you come up with from a Macro.
You can do that. Just keep the first line of the converted VBA code starting with "Function...". I would recommend changing the name so that it is named different from the original Macro name.
For this example, let's that the name (first line) of our converted code now looks like this:

Function MyCode()

Then, in a new Macro, select the RunCode action, and enter the name of your VBA code, like this: MyCode()

Now, when you click the Macro, it will run that code.

Could you give n example?

I understand what you said but I am afraid I willl mess uo the syntax.

Any help appreciated. Thanks in advance.

Respectfully,

Lou Reed

[Lou_Reed]

In this method that you talk about why not just call the Function. Use something like

Call MyCode()

It just seems more direct. Also, where is the source for Function MyCode()? In the navigation pane?

Also, why give it a different name from the macro name?

Any help appreciated. Thanks in advance.

Respectfully,

Lou Reed

[Lou_Reed]

I really need an answer to this questions. I am doing what I was told to on this forum,. but I think my option of just calling the function instead of running a macro that runs the code is a good idea. Also, my two questions about that need to be answered.

Any help appreciated. thanks in advance.

Respectfully,

Lou Reed