Using IIf statement in event procedure for onclick. first half works, but not when cdmarker =ss

[Abacus1234]

I'm using this IIf statement in event procedure for onclick. If cdmarker =cd, it works, but if it equals ss, I want it to do the else. Any help would be appreciated.

Private Sub Copy411_Click()


'If FIsLoaded("FEditHUD") Then
If Forms!FEditHud!cdmarker = "cd" Then
Call CopyTwoFields("FSettlementPage1","Text694", "text700", "K411c", "K411")
Else
Call CopyTwoFields("FSettlementPage1","J112c", "J112", "K411c", "K411")
End If
'End If

End Sub

[June7]

What happens when code runs - error message, wrong results, nothing?

What is cdmarker - a field name? Is this a text type field?

This code is behind form FEditHud?

What are Text694 and text700 - textboxes on FEditHud? Why are these references within quote marks - do you need the values of the textboxes or the textbox names passed as argument parameters?

[ssanfu]

And what is the code for the subroutine "CopyTwoFields"?

In addition to June's comments, I would probably use the "Select Case" construct instead of "IF()"

Private Sub Copy411_Click()

    Select Case Forms!FEditHud!cdmarker
        Case "cd"
            Call CopyTwoFields("FSettlementPage1", "Text694", "text700", "K411c", "K411")
        Case "ss"
            Call CopyTwoFields("FSettlementPage1", "J112c", "J112", "K411c", "K411")
        Case Else
            MsgBox "Oops!!"
    End Select

End Sub

My $0.02 worth...........

[trevor40]

beat me to it.

[orange]

Further to the comments so far, and along the line of June's questions, it is easier for you and for anyone trying to read/maintain the code, if you would give meaningful names to fields, objects, controls etc.
Text694 , text700 mean nothing to the application nor anyone trying to follow the logic flow.
This is all part of design, allocate time to do the analysis and design.

When you are posting code, use code tags --highlight the code involved then click on the # in the header of the reply area.

If you are doing any amount of Access/vba work, I strongly recommend you obtain these 2 free utilities:
SmartIndenter and MZTools for VBA.
Good luck with your project.

[Abacus1234]

I have used the Selected Case suggested by Steve and it works great. The cd marker field is on a Form called FEditHUD which allows me to choose which view of the data entry form I will use. The event procedure is behind the data entry form not FEditHUD.
Text 694 etc are text boxes on the data entry form that look up data on a third form. I can then reference these values when I am in the data entry form. I went through a lot of catch 22's to get here. So I am happy with the results. Thanks for the help.

[Abacus1234]

Thanks for the example of the Select Case. I have not used that in an event procedure. I have several other instances that I can now improve on. It worked like a dream.

[Abacus1234]

Function CopyFields(Source$, Destination$)

'Copy fields fromform Source$ to form Destination$.
'Only fields withmatching ControlSource names will be copied.

On Error ResumeNext 'Disable error trapping

For COUNTER = 1 ToForms(Source$).Count
'Try to get acontrol source for control Counter.
ControlField$ =Forms(Source$)(COUNTER).ControlSource

'Did we get acontrol source? (Err=0)
If Err = 0 Then
'We have asource. Try to copy it to the destination
Forms(Destination$)(ControlField$)= Forms(Source$)(ControlField$)
End If
Err = 0 'Clear any errors
Next COUNTER
End Function

[Abacus1234]

Thanks for the advise, and I will look at the utilities suggested.