Changing fields using an AfterUpdate event

[vad77]

I am interested to know if there is a better way of doing the the following updates.
I have the following fields on my form. They could be Null or have previous values.



HPAprroval - Verbal, Pending or Approved (Yes I know when I created my table I had a typo on the field name)
HRApprovalReqDate
HRApprovalDate.

If I change the HRApprovalReqDate I want it to change the HRAprroval to "Prending" and set the HRApproval date to NULL
When I enter a date in the HRAppoval date it will then change HRAprroval to "Approved".

On the AfterUpdate event of HRApprovalReqDate I have the following code.

Private Sub HRApprovalReqDate_AfterUpdate()
Me.HRAprroval.Value = "Pending"
Me.HRApprovalDate.Value = ""
End Sub

This works

In the AfterUpdate event of HRApprovalDate I have the following.


Private Sub HRApprovalDate_AfterUpdate()
Me.HRAprroval = "Approved"
End Sub

This also works but I am wondering if there is a better way to accompish these changes. One problem I can see is if I need to just wipe out the Approval date for what ever reason it then always change my HRApproval to Approve.
There might be an instance where my HRApproval is set to "Pending", if I remove the approval date it will then change HRP Approval to Approved when it needs to stay as Pending.
Thanks in advance for your repsonses.

Vito

[June7]

Saving calculated data is usually unnecessary and often bad design.

The status can be calculated based on whether or not the date fields have value. There is no need to store the status.

The 'verbal' parameter is oddity. Under what condition does it apply?


If IsNull(HRAprroval) Then
Me.HRAprroval = "Pending"
Else
Me.HRAprroval = "Approved"
End If


BTW, changing the field name shouldn't be too difficult.

[vad77]

Thanks again June7, I originally was going to go with 3 command button to change approval status and the buttons are still on my form. It was my manager that made the request to change status when the date is added or changed. I would rather stay with the command button and just add code to null out the date on the HRApproval date field. I can see issues with haveing code in the AfterUpdate event of my date fields.
But let me ask another question. I have done MsgBox before but can I program my "Approved" command button to set HRApproval to "Approved" and then have an input box pop-up and ask for an approval date and store that value in the HRApprovalDate field?

[June7]

Yes, but using popups for data entry is tricky. Validating the input can be a challenge. Example:

            strInput = "?"
            While strInput = "?"
                strInput = InputBox("Select Flat-Elongated ratios to test." & vbCrLf & vbCrLf & _
                "     3     1:3" & vbCrLf & vbCrLf & _
                "     5     1:5" & vbCrLf & vbCrLf & _
                "     B     Both")
                If strInput = "3" Or strInput = "5" Or strInput = "B" Then
                    Condition = UCase(strInput)
                Else
                    MsgBox "Not an appropriate entry.", vbApplicationModal, "Entry Error"
                    strInput = "?"
                End If
            Wend

Again, just calculating the status descriptor when needed is possible and really easier.

[vad77]

That is what I thought, I'll stick with my simple solution it's not like these fileds get updated every day.
The command buttons I have work just fine. I just added a line to my Pending button to remove that approval date.
Thanks one more time June7.
i'll just leave this thread open for one more day.