Better way to turn visible properties on and off

[rand605]

I have a form with a number of controls on it. Based what the user select from the first dropdown list, controls will become visible. This is the code that does this:

Select Case WasteWaterDisposalTypeID
Case 1
Me.Disposal_Tank_Type_Label.Visible = True
Me.TankTypeID.Visible = True
Me.Disposal_Tank_Size__gallons__Label.Visible = True
Me.TankSizeID.Visible = True
Me.Type_of_Pipe_Label.Visible = True
Me.PipeTypeID.Visible = True
Me.LengthPipe_Label.Visible = True
Me.LengthPipeLabel.Visible = True
Me.FieldLength_Label.Visible = True
Me.PipeFieldLength.Visible = True
Me.FieldLengthIn_label.Visible = True
Me.PipeFieldLengthIn.Visible = True
Me.FieldLengthFtIn_label.Visible = True
Me.PipeFieldLengthFt.Visible = True
Me.HouseToTankLength_Label.Visible = True
Me.HouseToTankLength.Visible = True
Me.HouseToTankLengthIn_Label.Visible = True
Me.HouseToTankLengthIn.Visible = True
Me.HouseToTankLengthFt_Label.Visible = True
Me.HouseToTankLengthFt.Visible = True
Me.TankToDaylight_Label.Visible = True
Me.TankToDayLightLength.Visible = True
Me.TankToDayLightLengthIn_Label.Visible = True
Me.TankToDayLightLengthIn.Visible = True
Me.TankToDayLightLengthFt_Label.Visible = True
Me.TankToDayLightLengthFt.Visible = True
Me.NumberOfCleanOuts_Label.Visible = True
Me.NumberOfCleanOuts.Visible = True



End Select



My question is there a better way to do this instead of having to to each control seperately?

[llkhoutx]

There's nothing wrong with the way you are doing it.

You could store a flag, i.e. 1, in the tag property of each of those controls, then on the Select Case event cycle through all form controls, testing their flag property and hide/display them as appropriate. The advantage of this is that you can add control and set their tag property appropriately and no code needs to be changed.

[dcrake]

Also if the label is associated to the control then you do not need to make the lable visible/invisible. That will reduce it by 50%

David

[rand605]

Could you send me a example of using the case statement using the tag statement.

[sesproul]

Public Function SwitchVisibleByTag (Byval v_bVisible as boolean, ByVal v_sTag as string)
'---Pass in on or off for visible through the v_bVisible parameter
'---Also pass in the TAG identifier to search for (This is a generic function)


Dim ocontrol As Control


Select Case WasteWaterDisposalTypeID
Case 1

     'check every control for the tag and then appropriately set visibility
     For Each ocontrol In Me.Controls '---replace Me. with a specific form, or pass in the form parameter if function lives outside the form module.
         If ocontrol.Tag = v_sTag Then ocontrol.Visible = v_bVisible
     Next

end Select


end Function

[llkhoutx]

dim ctl as control
Select Case WasteWaterDisposalTypeID
Case 1
for each ctl in me
if me.ctl.tag=1 them
me.ctl.visible = false
else
me.ctl.visible=true
end if
next
Case else ' to turn all controls visible
for each ctl in me
me.ctl.visible=true
next
EndSelect