Concat textbox name with string

[dwif]

Hi,

greetings for all access experts in this forum

I got problems when trying to concat between my text box name with string.
In my form there are 10 textboxs named : Student1, Student2, Student3... Student10
I tried to get value from each textbox
This is my code :

Dim a as string
a = 1
do until a = 2
MsgBox (Me.Controls("Student"&a).Value)
a = a+1
loop

It's not working. No error also.
Any help would be appreciated.
Many thanks.

[amrut]

the variable "a" is declared as string. the result of a = a+1 is "a + 1" and not 2. Declare it as number (integer).
further to concat, the the values should be joined by "&". for ex. the result of Me.txtStudent.value & 1 is StudentName1

[June7]

VBA will take a string variable and perform math calc. If the variable has only numeric characters and all the other terms of the expression are numeric then the + will sum. However, use + with 2 string variables and they will concatenate. The + is valid concatenation operator left over from ancient BASIC. The & is preferred concatenation operator in VBA but the + still works and must be careful with it. So amrut's point is still valid, properly declaring variables should be foremost consideration in writing code.

Here is a little test that will demonstrate:

Sub test()
Dim a As String, b As String, i As Integer
a = 2
b = 3
Debug.Print a + b 'the output is concatenation
Debug.Print a + 1 'the output is sum and is numeric type
For i = 1 To 5
a = a + i
Debug.Print a 'the output is sum and is string type
Next
End Sub

So your looping code should work. It should generate only 1 MsgBox popup because of the Do Until a = 2 limitation. Why do you say it isn't? What happens - if no error message then are the results incorrect or nothing happens?

Try alternative loop that doesn't require incrementing with +, let VBA do it for you:
For i = 1 to 10
MsgBox Me.("Student" & i)
Next

Why do you have multiple similar name textboxes? Makes me think the data structure is not normalized.

The .Value is not needed because Value is default property.