Error 438 with a simple code

[Seiquo]

Hello Forum,



I am trying to open a form and lock all controls in said form. There are also two subforms in this form and I would like their controls to be locked too.

I'm trying to work around the following code but my skills in VBA being what they are, I am stuck...

Private Sub CmdOpenPersonal_Click()
Dim ctrl As Control

DoCmd.Close 'closes the main "welcome" form where CmdOpenPersonal button is
DoCmd.OpenForm "FmPersonalInfo"

For Each ctrl In Forms("FmPersonalInfo").Controls
     ctrl.Locked = True
Next ctrl
End Sub

Each time I click on CmdOpenGeneral, I get the "Error 438 - object doesn't support this property or method" and VBA points to ctrl.Locked = True

Is it because two of the controls in my form are subforms?

Your help would be much appreciated... And thank you in advance.

[Gicu]

You are getting that probably because your code is trying to lock a label or other control (line, rectangle) that has no value property. You can add On Error Resume Next at the beginning of the sub or check the control type (https://docs.microsoft.com/en-us/off...ox.controltype).
if ctrl.Controltype=actextbox or ctrl.Controltype=acCombobox .... then
Cheers,
Vlad

[June7]

Instead of the locking code, try:

DoCmd.OpenForm "FmPersonalInfo", , , , acFormReadOnly

[Seiquo]

Thank you Gicu and June 7,

Gicu, isn't the purpose of

dim ctrl as control

preventing the kind of problem you are writing about?? I am confused...

June7,
In this form, I have a combobox that allows users to pick a name and refresh the query in order to display the appropriate information. I cannot use the acFormReadOnly option unfortunately.

[Gicu]

A label is also a control and you cannot lock a label....

You can set the form's recordset type to snapshot and that should allow your combobox to still work.

Cheers,
Vlad

[Seiquo]

Thank you Gicu!

I didn't know a label was also a control, speaking of forms. You taught me something!

Then I suppose I should add this to my code:

For Each ctrl In Me.Controls
  If TypeOf ctrl Is TextBox Then
   ctrl.Locked = True
  End If

My problem is I also have checkboxes and combos. I want everything locked except the unbound combo that allows to filter the information).

How can I do this?

Should it be too complicated, my last option is to reference the controls one by one in my code...

[Gicu]

if ctrl.ControlType=acTextBox Or ctrl.ControlType=acComboBox Or ctrl.ControlType=acCheckBox Or ctrl.ControlType=acListBox Then Ctrl.Locked=True

Have you tried to see if changing the recordsettype of the form works for you? Forms!YourFormName.Form.RecordsetType = 2 'snapshot (or Me.RecordsetType =2 if the code is on the same form)

Cheers,
Vlad