formatting issue

[aamer]

Need assistance

I am trying to add 3 zeros before the value. If the value is 1 it should convert to 0001 and 1000 should read as 1000
please guide me where am making a mistake.

NewFileName = NewFilePath & TransactionID.Value Format(TransactionID, "000") & " " & "CoID-" & PurCoId.Value & " NEXPPur-Att1" & Right(oldFileName, 4)


following is the the complete Event.

Private Sub AttachmentA_Click()
If IsNull(AttachmentA.Value) Or AttachmentA.Value = "" Then


Dim fDialog As Object
Dim oldFileName, OldFilePath, NewFileName, NewFilePath As String
Dim varFile As Variant

NewFilePath = "H:\2018-2019 Ledgers\Office Attachments 2018-2019\Lahore\NEXP LHE Purchase"


' Set up the File Dialog. '
Set fDialog = Application.FileDialog(3)


With fDialog


' Set the title of the dialog box. '
.Title = "Please select the image to attach"


' Clear out the current filters, and add our own.'
.Filters.Clear
.Filters.Add "JPEG Images", "*.JPG"
.Filters.Add "PNG Images", "*.PNG"
.Filters.Add "GIF Images", "*.GIF"
.Filters.Add "XLSX document", "*.xlsx"
.Filters.Add "DOCS document", "*.docx"
.Filters.Add "PDF document", "*.PDF"
.Filters.Add "All Files", "*.*"


.AllowMultiSelect = False

If .Show = -1 Then
oldFileName = .SelectedItems(1)
'NewFileName = NewFilePath & TransactionID.Value & " " & "CoID-" & PurCoId.Value & " NEXPPur-Att1" & Right(oldFileName, 4)
NewFileName = NewFilePath & TransactionID.Value Format(TransactionID, "000") & " " & "CoID-" & PurCoId.Value & " NEXPPur-Att1" & Right(oldFileName, 4)
FileCopy oldFileName, NewFileName


AttachmentA.Value = NewFileName
Else
MsgBox "File selection cancelled!"
End If


End With
Else
Application.FollowHyperlink AttachmentA.Value
End If
End Sub

[moke123]

I think you need more 0's.

Format(TransactionID, "0000")

[ssanfu]

Also, this line

Dim oldFileName, OldFilePath, NewFileName, NewFilePath As String

doesn't do what you think. (unless you want "oldFileName", "OldFilePath" & "NewFileName" Variants)
"oldFileName", "OldFilePath" & "NewFileName" are defaulting to Variants and only "NewFilePath" is being declared as a String.

In VBA, you must explicitly declare variable types.
You can use

Dim oldFileName As String, OldFilePath As String, NewFileName As String, NewFilePath As String

or

Dim oldFileName As String
Dim OldFilePath As String
Dim NewFileName As String
Dim NewFilePath As String

[Micron]

Dang! While I was composing in NotePad for a copy/paste dump, someone beat me to the punch again. That's OK, as it was only a jab. Here comes a round-house punch

Pullleeez put lengthy code samples within code tags with nice indentation. Not sure I see the need for all those filters if you're going to end with *.* anyway.
Last points:
- .Value is the default property of most form data controls, so you don't need to employ it.
- I'm not a big fan of declaring variables inside an IF block. Setting, OK; declaring no. To each their own, I guess.

Private Sub AttachmentA_Click()
Dim fDialog As Object
Dim oldFileName As String, OldFilePath As String
Dim NewFileName As String, NewFilePath As String
Dim varFile As Variant

If IsNull(AttachmentA) Or AttachmentA = "" Then
  NewFilePath = "H:\2018-2019 Ledgers\Office Attachments 2018-2019\Lahore\NEXP LHE Purchase"

  ' Set up the File Dialog. '
  Set fDialog = Application.FileDialog(3)
  With fDialog
  ' Set the title of the dialog box. '
   .Title = "Please select the image to attach"

  ' Clear out the current filters, and add our own.'
   .Filters.Clear
   .Filters.Add "All Files", "*.*"
   .AllowMultiSelect = False
   If .Show = -1 Then 
     oldFileName = .SelectedItems(1)
     'NewFileName = NewFilePath & TransactionID & " " & "CoID-" & PurCoId & " NEXPPur-Att1" & Right(oldFileName, 4)
     NewFileName = NewFilePath & TransactionID Format(TransactionID, "000") & " " & "CoID-" & PurCoId & " NEXPPur-Att1" & Right(oldFileName, 4)
     FileCopy oldFileName, NewFileName
     AttachmentA = NewFileName
   Else
     MsgBox "File selection cancelled!"
     Exit Sub '<< code may attempt to follow hyperlink when no file was selected. Then again, maybe not but I would Exit to be sure
   End If
  End With

Else
  Application.FollowHyperlink AttachmentA
End If

End Sub

[moke123]

Going back to your question...

I am trying to add 3 zeros before the value. If the value is 1 it should convert to 0001 and 1000 should read as 1000
please guide me where am making a mistake.

NewFileName = NewFilePath & TransactionID.Value Format(TransactionID, "000") & " " & "CoID-" & PurCoId.Value & " NEXPPur-Att1" & Right(oldFileName, 4)

It's my understanding that when you format a number as your doing, the 0's represent place holders. So 000 would be a 3 digit number
Format(12,"000") would be 012.
Format(12,"0000") would be 0012.
Format(12,"000000") would be 000012.
Format(30412,"000000") would be 030412.

[Micron]

True, everything up to 99 would be prefaced with a zero. After that, no.
Can also use 000#, as in format (50,"000#")